Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/profiler/native_stack_sampler_win.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process/process_util_unittest.cc ('k') | base/synchronization/waitable_event_win.cc » ('j') | chrome/browser/autofill/form_structure_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/profiler/native_stack_sampler_win.cc
diff --git a/base/profiler/native_stack_sampler_win.cc b/base/profiler/native_stack_sampler_win.cc
index e1605109fe960d769523733b2a1190700b250d28..2e4ad030a7472a37dbd1c210acd0ca8b07ed9176 100644
--- a/base/profiler/native_stack_sampler_win.cc
+++ b/base/profiler/native_stack_sampler_win.cc
@@ -301,7 +301,8 @@ ScopedSuspendThread::~ScopedSuspendThread() {
ScopedDisablePriorityBoost disable_priority_boost(thread_handle_);
bool resume_thread_succeeded =
::ResumeThread(thread_handle_) != static_cast<DWORD>(-1);
- CHECK(resume_thread_succeeded) << "ResumeThread failed: " << GetLastError();
+ // ResumeThread failed.
+ CHECK(resume_thread_succeeded);
}
// Tests whether |stack_pointer| points to a location in the guard page.
« no previous file with comments | « base/process/process_util_unittest.cc ('k') | base/synchronization/waitable_event_win.cc » ('j') | chrome/browser/autofill/form_structure_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698