Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2561553002: [LayoutNG] Remove unnecessary #includes (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
ikilpatrick, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Remove unnecessary #includes NOTRY=true BUG=591099 Committed: https://crrev.com/17c9aaca8957853d7582f77eed0e29bb5b837679 Cr-Commit-Position: refs/heads/master@{#437217}

Patch Set 1 #

Patch Set 2 : Forgot to test-compile unit tests locally, apparently. #

Patch Set 3 : Let's see if Windows is more happy now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -60 lines) Patch
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_coordinator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_fragment.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.h View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 35 (19 generated)
mstensho (USE GERRIT)
God morron, Sverige! :)
4 years ago (2016-12-07 10:18:57 UTC) #2
ikilpatrick
lgtm
4 years ago (2016-12-07 18:26:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561553002/1
4 years ago (2016-12-07 18:26:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/351748) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-07 18:44:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561553002/20001
4 years ago (2016-12-07 20:25:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/134658)
4 years ago (2016-12-07 21:18:05 UTC) #15
eae
LGTM!
4 years ago (2016-12-07 21:24:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561553002/40001
4 years ago (2016-12-07 21:38:21 UTC) #19
mstensho (USE GERRIT)
I just introduced an empty and explicit ~NGBlockNode(), which will hopefully make the Windows compiler ...
4 years ago (2016-12-07 21:42:04 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/81450)
4 years ago (2016-12-07 23:09:59 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561553002/40001
4 years ago (2016-12-08 07:39:22 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82105)
4 years ago (2016-12-08 08:47:12 UTC) #26
mstensho (USE GERRIT)
Some android trybot is having unrelated issues. Adding NOTRY=true - all other bots are green.
4 years ago (2016-12-08 08:54:13 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561553002/40001
4 years ago (2016-12-08 08:54:37 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 09:01:10 UTC) #33
commit-bot: I haz the power
4 years ago (2016-12-08 09:04:01 UTC) #35
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/17c9aaca8957853d7582f77eed0e29bb5b837679
Cr-Commit-Position: refs/heads/master@{#437217}

Powered by Google App Engine
This is Rietveld 408576698