Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

Issue 2561553002: [LayoutNG] Remove unnecessary #includes (Closed)
Patch Set: Let's see if Windows is more happy now. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
index 1114647c3ce40dfb82dc8e883b8b494a227723e2..c9c627e27e6f470364f368431a1645327faddafd 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
@@ -11,14 +11,13 @@
#include "core/layout/ng/ng_block_layout_algorithm.h"
#include "core/layout/ng/ng_constraint_space_builder.h"
#include "core/layout/ng/ng_constraint_space.h"
-#include "core/layout/ng/ng_inline_layout_algorithm.h"
#include "core/layout/ng/ng_fragment.h"
#include "core/layout/ng/ng_fragment_builder.h"
+#include "core/layout/ng/ng_inline_node.h"
#include "core/layout/ng/ng_layout_coordinator.h"
#include "core/layout/ng/ng_length_utils.h"
#include "core/layout/ng/ng_writing_mode.h"
#include "platform/RuntimeEnabledFeatures.h"
-#include "platform/text/TextDirection.h"
namespace blink {
@@ -35,6 +34,11 @@ NGBlockNode::NGBlockNode(ComputedStyle* style)
DCHECK(style_);
}
+// Need an explicit destructor in the .cc file, or the MSWIN compiler will
+// produce an error when attempting to generate a default one, if the .h file is
+// included from a compilation unit that lacks the ComputedStyle definition.
+NGBlockNode::~NGBlockNode() {}
+
bool NGBlockNode::Layout(const NGConstraintSpace* constraint_space,
NGFragmentBase** out) {
DCHECK(!minmax_algorithm_)

Powered by Google App Engine
This is Rietveld 408576698