Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2561043002: Clean-up after Form Association Refactoring (Closed)

Created:
4 years ago by yurak
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, dominicc (has gone to gerrit), eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, kinuko+watch, loading-reviews+parser_chromium.org, mlamouri+watch-blink_chromium.org, rwlbuis, sof, nessy, Srirama, vcarbune.chromium, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up after refactoring form association. - Remove HTMLFormElement argument from HTML element constructors - Remove HTMLFormElement argument from HTMLElementFactory - Update unit tests BUG=672359 Committed: https://crrev.com/1decd675fa03b9a63bde83e9ae1c2aea66ce36b8 Cr-Commit-Position: refs/heads/master@{#437475}

Patch Set 1 #

Patch Set 2 : Remove redundant code path/arguments #

Total comments: 6

Patch Set 3 : Removed constructorNeedsFormElement from scripts and HTMLTagNames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -138 lines) Patch
M third_party/WebKit/Source/build/scripts/make_element_factory.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/make_element_lookup_trie.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/make_element_type_helpers.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl View 4 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ElementFactory.h.tmpl View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLButtonElement.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLButtonElement.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 3 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLKeygenElement.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOutputElement.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOutputElement.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOutputElementTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTagNames.in View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHelperPluginImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
yurak
PTL.
4 years ago (2016-12-09 01:17:40 UTC) #4
tkent
You need update - core/html/HTMLTagNames.in: Remove constructorNeedsFormElement flag - build/scripts/*.py: Remove code for constructorNeedsFormElement https://codereview.chromium.org/2561043002/diff/20001/third_party/WebKit/Source/core/html/HTMLButtonElement.h ...
4 years ago (2016-12-09 01:27:30 UTC) #5
yurak
On 2016/12/09 at 01:27:30, tkent wrote: > You need update > - core/html/HTMLTagNames.in: Remove constructorNeedsFormElement ...
4 years ago (2016-12-09 02:20:05 UTC) #7
tkent
lgtm
4 years ago (2016-12-09 05:13:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561043002/40001
4 years ago (2016-12-09 05:14:12 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-09 05:20:46 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-09 05:23:40 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1decd675fa03b9a63bde83e9ae1c2aea66ce36b8
Cr-Commit-Position: refs/heads/master@{#437475}

Powered by Google App Engine
This is Rietveld 408576698