Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp

Issue 2561043002: Clean-up after Form Association Refactoring (Closed)
Patch Set: Removed constructorNeedsFormElement from scripts and HTMLTagNames Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
index 5e7b3e25519a396b58dcff0492a81a72585394cd..d6c7f288b5f0b2b0d9caf8ccbb3aba3aac66ff9f 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
@@ -85,12 +85,11 @@ TEST_F(HTMLInputElementTest, FilteredDataListOptionsForMultipleEmail) {
}
TEST_F(HTMLInputElementTest, create) {
- HTMLInputElement* input = HTMLInputElement::create(
- document(), nullptr, /* createdByParser */ false);
+ HTMLInputElement* input =
+ HTMLInputElement::create(document(), /* createdByParser */ false);
EXPECT_NE(nullptr, input->userAgentShadowRoot());
- input =
- HTMLInputElement::create(document(), nullptr, /* createdByParser */ true);
+ input = HTMLInputElement::create(document(), /* createdByParser */ true);
EXPECT_EQ(nullptr, input->userAgentShadowRoot());
input->parserSetAttributes(Vector<Attribute>());
EXPECT_NE(nullptr, input->userAgentShadowRoot());
@@ -122,15 +121,14 @@ TEST_F(HTMLInputElementTest, NoAssertWhenMovedInNewDocument) {
TEST_F(HTMLInputElementTest, DefaultToolTip) {
HTMLInputElement* inputWithoutForm =
- HTMLInputElement::create(document(), nullptr, false);
+ HTMLInputElement::create(document(), false);
inputWithoutForm->setBooleanAttribute(HTMLNames::requiredAttr, true);
document().body()->appendChild(inputWithoutForm);
EXPECT_EQ("<<ValidationValueMissing>>", inputWithoutForm->defaultToolTip());
HTMLFormElement* form = HTMLFormElement::create(document());
document().body()->appendChild(form);
- HTMLInputElement* inputWithForm =
- HTMLInputElement::create(document(), nullptr, false);
+ HTMLInputElement* inputWithForm = HTMLInputElement::create(document(), false);
inputWithForm->setBooleanAttribute(HTMLNames::requiredAttr, true);
form->appendChild(inputWithForm);
EXPECT_EQ("<<ValidationValueMissing>>", inputWithForm->defaultToolTip());
@@ -141,8 +139,7 @@ TEST_F(HTMLInputElementTest, DefaultToolTip) {
// crbug.com/589838
TEST_F(HTMLInputElementTest, ImageTypeCrash) {
- HTMLInputElement* input =
- HTMLInputElement::create(document(), nullptr, false);
+ HTMLInputElement* input = HTMLInputElement::create(document(), false);
input->setAttribute(HTMLNames::typeAttr, "image");
input->ensureFallbackContent();
// Make sure ensurePrimaryContent() recreates UA shadow tree, and updating
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLKeygenElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698