Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2561043002: Clean-up after Form Association Refactoring (Closed)
Patch Set: Remove redundant code path/arguments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2000 Dirk Mueller (mueller@kde.org) 5 * (C) 2000 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights
7 * reserved. 7 * reserved.
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 class HTMLElementOrLong; 47 class HTMLElementOrLong;
48 class PopupMenu; 48 class PopupMenu;
49 49
50 class CORE_EXPORT HTMLSelectElement final 50 class CORE_EXPORT HTMLSelectElement final
51 : public HTMLFormControlElementWithState, 51 : public HTMLFormControlElementWithState,
52 private TypeAheadDataSource { 52 private TypeAheadDataSource {
53 DEFINE_WRAPPERTYPEINFO(); 53 DEFINE_WRAPPERTYPEINFO();
54 54
55 public: 55 public:
56 static HTMLSelectElement* create(Document&); 56 static HTMLSelectElement* create(Document&);
57 static HTMLSelectElement* create(Document&, HTMLFormElement*);
58 ~HTMLSelectElement() override; 57 ~HTMLSelectElement() override;
59 58
60 int selectedIndex() const; 59 int selectedIndex() const;
61 void setSelectedIndex(int); 60 void setSelectedIndex(int);
62 // `listIndex' version of |selectedIndex|. 61 // `listIndex' version of |selectedIndex|.
63 int selectedListIndex() const; 62 int selectedListIndex() const;
64 63
65 // For ValidityState 64 // For ValidityState
66 String validationMessage() const override; 65 String validationMessage() const override;
67 bool valueMissing() const override; 66 bool valueMissing() const override;
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 void showPopup(); 165 void showPopup();
167 void hidePopup(); 166 void hidePopup();
168 PopupMenu* popup() const { return m_popup.get(); } 167 PopupMenu* popup() const { return m_popup.get(); }
169 void didMutateSubtree(); 168 void didMutateSubtree();
170 169
171 void resetTypeAheadSessionForTesting(); 170 void resetTypeAheadSessionForTesting();
172 171
173 DECLARE_VIRTUAL_TRACE(); 172 DECLARE_VIRTUAL_TRACE();
174 173
175 protected: 174 protected:
176 HTMLSelectElement(Document&, HTMLFormElement*); 175 HTMLSelectElement(Document&);
tkent 2016/12/09 01:27:30 Prepend 'explicit'
177 176
178 private: 177 private:
179 const AtomicString& formControlType() const override; 178 const AtomicString& formControlType() const override;
180 179
181 bool shouldShowFocusRingOnMouseFocus() const override; 180 bool shouldShowFocusRingOnMouseFocus() const override;
182 181
183 void dispatchFocusEvent(Element* oldFocusedElement, 182 void dispatchFocusEvent(Element* oldFocusedElement,
184 WebFocusType, 183 WebFocusType,
185 InputDeviceCapabilities* sourceCapabilities) override; 184 InputDeviceCapabilities* sourceCapabilities) override;
186 void dispatchBlurEvent(Element* newFocusedElement, 185 void dispatchBlurEvent(Element* newFocusedElement,
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 306
308 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption); 307 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption);
309 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption); 308 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption);
310 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption); 309 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption);
311 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption); 310 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption);
312 }; 311 };
313 312
314 } // namespace blink 313 } // namespace blink
315 314
316 #endif // HTMLSelectElement_h 315 #endif // HTMLSelectElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698