Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

Issue 2561043002: Clean-up after Form Association Refactoring (Closed)
Patch Set: Removed constructorNeedsFormElement from scripts and HTMLTagNames Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl
index 476adf5a722757cae57c9bb8862af822b452a25a..47abffadedbc6fac1b98ccf3d37e20c85b984235 100644
--- a/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl
@@ -26,9 +26,6 @@ using namespace {{namespace}}Names;
typedef {{namespace}}Element* (*ConstructorFunction)(
Document&,
- {% if namespace == 'HTML' %}
- HTMLFormElement*,
- {% endif %}
CreateElementFlags);
typedef HashMap<AtomicString, ConstructorFunction> FunctionMap;
@@ -38,9 +35,6 @@ static FunctionMap* g_constructors = 0;
{% for tag in tags|sort if not tag.noConstructor %}
static {{namespace}}Element* {{tag|symbol}}Constructor(
Document& document,
- {% if namespace == 'HTML' %}
- HTMLFormElement* formElement,
- {% endif %}
CreateElementFlags flags) {
{% if tag.runtimeEnabled %}
if (!RuntimeEnabledFeatures::{{tag.runtimeEnabled}}Enabled())
@@ -49,7 +43,6 @@ static {{namespace}}Element* {{tag|symbol}}Constructor(
return {{tag.interface}}::create(
{%- if tag.multipleTagNames %}{{tag|symbol}}Tag, {% endif -%}
document
- {%- if namespace == 'HTML' and tag.constructorNeedsFormElement %}, formElement{% endif -%}
{%- if tag.constructorNeedsCreatedByParser %}, flags & CreatedByParser{% endif -%}
);
}
@@ -77,14 +70,11 @@ static void create{{namespace}}FunctionMap() {
{{namespace}}Element* {{namespace}}ElementFactory::create{{namespace}}Element(
const AtomicString& localName,
Document& document,
- {% if namespace == 'HTML' %}
- HTMLFormElement* formElement,
- {% endif %}
CreateElementFlags flags) {
if (!g_constructors)
create{{namespace}}FunctionMap();
if (ConstructorFunction function = g_constructors->get(localName))
- return function(document, {% if namespace == 'HTML' %}formElement, {% endif %}flags);
+ return function(document, flags);
{% if namespace == 'HTML' %}
// createElement handles custom element creation itself in order to

Powered by Google App Engine
This is Rietveld 408576698