Cleanup CFWL_Widget code to return CFX_RectFs where appropriate

Cleanup CFWL_Widget code to return CFX_RectFs where appropriate

This Cl changes the various Get*Rect methods in CFWL_Widget to return CFX_RectF
classes instead of taking an out parameter. The Repaint method is split into
Repaint() and RepaintRect() in order to change the param to a const CFX_RectF&
from a CFX_RectF*.

Committed: https://pdfium.googlesource.com/pdfium/+/43ac44cbf52076fd2354d5276c95d5b4b4a06d64

[dsinclair, 2016-12-08 16:05:38]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-12-08 16:05:39]

PTAL.

[dsinclair, 2016-12-08 16:05:43]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 16:05:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 16:19:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 16:19:15]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-08 19:16:21]

https://codereview.chromium.org/2560873005/diff/1/xfa/fwl/cfwl_widget.cpp
File xfa/fwl/cfwl_widget.cpp (right):

https://codereview.chromium.org/2560873005/diff/1/xfa/fwl/cfwl_widget.cpp#new...
xfa/fwl/cfwl_widget.cpp:168: if (HasEdge() && GetEdgeRect().Contains(fx, fy))
nice.

https://codereview.chromium.org/2560873005/diff/1/xfa/fwl/cfwl_widget.cpp#new...
xfa/fwl/cfwl_widget.cpp:355: rect.left = rect.top = 0;
nit: separate lines.

https://codereview.chromium.org/2560873005/diff/1/xfa/fwl/cfwl_widget.cpp#new...
xfa/fwl/cfwl_widget.cpp:601: rect.left = rect.top = 0;
ditto

https://codereview.chromium.org/2560873005/diff/1/xfa/fxfa/app/xfa_fwladapter...
File xfa/fxfa/app/xfa_fwladapter.cpp (right):

https://codereview.chromium.org/2560873005/diff/1/xfa/fxfa/app/xfa_fwladapter...
xfa/fxfa/app/xfa_fwladapter.cpp:25: pFFWidget->AddInvalidateRect(nullptr);
this is strange.  I'd expect they'd pass the rect argument into here.  we may be
drawing more than necessary.

[dsinclair, 2016-12-08 19:20:47]

https://codereview.chromium.org/2560873005/diff/1/xfa/fwl/cfwl_widget.cpp
File xfa/fwl/cfwl_widget.cpp (right):

https://codereview.chromium.org/2560873005/diff/1/xfa/fwl/cfwl_widget.cpp#new...
xfa/fwl/cfwl_widget.cpp:355: rect.left = rect.top = 0;
On 2016/12/08 19:16:20, Tom Sepez wrote:
> nit: separate lines.

Done.

https://codereview.chromium.org/2560873005/diff/1/xfa/fwl/cfwl_widget.cpp#new...
xfa/fwl/cfwl_widget.cpp:601: rect.left = rect.top = 0;
On 2016/12/08 19:16:20, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/2560873005/diff/1/xfa/fxfa/app/xfa_fwladapter...
File xfa/fxfa/app/xfa_fwladapter.cpp (right):

https://codereview.chromium.org/2560873005/diff/1/xfa/fxfa/app/xfa_fwladapter...
xfa/fxfa/app/xfa_fwladapter.cpp:25: pFFWidget->AddInvalidateRect(nullptr);
On 2016/12/08 19:16:20, Tom Sepez wrote:
> this is strange.  I'd expect they'd pass the rect argument into here.  we may
be
> drawing more than necessary.

Possibly but I'm hesitant to change it until we understand what's happening.
From the AddInvalidateRect code we'll end up with a rect:

    GetBBox(rtWidget, XFA_WidgetStatus_Focused);
    rtWidget.Inflate(2, 2);

Which, looks like it will be 2px larger in each dimension then the focused
widget which won't be too much over-invalidation.

[Tom Sepez, 2016-12-08 21:01:37]

lgtm

[dsinclair, 2016-12-08 21:52:19]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-12-08 21:52:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 22:05:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481233939168100,
"parent_rev": "53ed03d9d865c312fdaa4434b83ed60619881226", "commit_rev":
"43ac44cbf52076fd2354d5276c95d5b4b4a06d64"}

[commit-bot: I haz the power, 2016-12-08 22:05:17]

Description was changed from

==========
Cleanup CFWL_Widget code to return CFX_RectFs where appropriate

This Cl changes the various Get*Rect methods in CFWL_Widget to return CFX_RectF
classes instead of taking an out parameter. The Repaint method is split into
Repaint() and RepaintRect() in order to change the param to a const CFX_RectF&
from a CFX_RectF*.
==========

to

==========
Cleanup CFWL_Widget code to return CFX_RectFs where appropriate

This Cl changes the various Get*Rect methods in CFWL_Widget to return CFX_RectF
classes instead of taking an out parameter. The Repaint method is split into
Repaint() and RepaintRect() in order to change the param to a const CFX_RectF&
from a CFX_RectF*.

Committed:
https://pdfium.googlesource.com/pdfium/+/43ac44cbf52076fd2354d5276c95d5b4b4a0...
==========

[commit-bot: I haz the power, 2016-12-08 22:05:18]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/43ac44cbf52076fd2354d5276c95d5b4b4a0...