xfa/fwl/cfwl_combolist.cpp - Issue 2560873005: Cleanup CFWL_Widget code to return CFX_RectFs where appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/cfwl_combolist.cpp

Issue 2560873005: Cleanup CFWL_Widget code to return CFX_RectFs where appropriate (Closed)

Patch Set: Review feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/cfwl_combolist.cpp

diff --git a/xfa/fwl/cfwl_combolist.cpp b/xfa/fwl/cfwl_combolist.cpp

index 4ec3abe072cb9cf66b97febc0d24bc9833ffc35c..1fa9acb68e4dedf000a2149e14b49e643e694d35 100644

--- a/xfa/fwl/cfwl_combolist.cpp

+++ b/xfa/fwl/cfwl_combolist.cpp

@@ -62,7 +62,7 @@ void CFWL_ComboList::ChangeSelected(int32_t iSel) {

SetSelItem(hSel, true);

}

if (!rtInvalidate.IsEmpty())

- Repaint(&rtInvalidate);

+ RepaintRect(rtInvalidate);

}

void CFWL_ComboList::ClientToOuter(FX_FLOAT& fx, FX_FLOAT& fy) {

@@ -236,7 +236,7 @@ void CFWL_ComboList::OnDropListKeyDown(CFWL_MessageKey* pKey) {

CFX_RectF rtInvalidate;

rtInvalidate.Set(0, 0, m_pProperties->m_rtWidget.width,

m_pProperties->m_rtWidget.height);

- Repaint(&rtInvalidate);

+ RepaintRect(rtInvalidate);

break;

}

default:

« no previous file with comments | « xfa/fwl/cfwl_comboedit.cpp ('k') | xfa/fwl/cfwl_datetimeedit.cpp » ('j') | no next file with comments »