Move xfa/fwl/core to xfa/fwl.

Move xfa/fwl/core to xfa/fwl.

The core/ directory in FWL no-longer provides any context. This Cl moves all
of the core/ files up to the fwl/ folder.

As well, the CFWL_EvtFoo files are renamed CFWL_EventFoo and the CFWL_MsgFoo
files are renamed CFWL_MessageFoo. The event and message preceed the type in
order to keep the files sorted together and to make it clear that they're all
related.

Committed: https://pdfium.googlesource.com/pdfium/+/447b1f3ffc7e0df233d15300bbf8a85ce2bc7278

[dsinclair, 2016-12-08 14:42:56]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-12-08 14:42:57]

PTAL. This is all mechanical file moves except for the Evt -> Event and Msg ->
Message change. I went with EventFoo and MessageFoo because it makes working
with the source a lot simpler as the files all end up grouped. I think they
still read fine in this order.

[dsinclair, 2016-12-08 14:42:59]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 14:43:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 14:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 14:57:52]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-08 17:41:47]

On 2016/12/08 14:42:57, dsinclair wrote:
> PTAL. This is all mechanical file moves except for the Evt -> Event and Msg ->
> Message change. I went with EventFoo and MessageFoo because it makes working
> with the source a lot simpler as the files all end up grouped. I think they
> still read fine in this order.

Similar changes planned for other xfa/fwl/... subdirectories?

[dsinclair, 2016-12-08 17:49:15]

On 2016/12/08 17:41:47, Tom Sepez wrote:
> On 2016/12/08 14:42:57, dsinclair wrote:
> > PTAL. This is all mechanical file moves except for the Evt -> Event and Msg
->
> > Message change. I went with EventFoo and MessageFoo because it makes working
> > with the source a lot simpler as the files all end up grouped. I think they
> > still read fine in this order.
> 
> Similar changes planned for other xfa/fwl/... subdirectories?


The only other fwl directory is theme/ which I'm going to leave as it makes
sense to keep the theme code together until we figure out what to do with it.
All other fwl/ directories have been either removed or merged into core/.

[Tom Sepez, 2016-12-08 18:02:25]

On 2016/12/08 17:49:15, dsinclair wrote:
> On 2016/12/08 17:41:47, Tom Sepez wrote:
> > On 2016/12/08 14:42:57, dsinclair wrote:
> > > PTAL. This is all mechanical file moves except for the Evt -> Event and
Msg
> ->
> > > Message change. I went with EventFoo and MessageFoo because it makes
working
> > > with the source a lot simpler as the files all end up grouped. I think
they
> > > still read fine in this order.
> > 
> > Similar changes planned for other xfa/fwl/... subdirectories?
> 
> 
> The only other fwl directory is theme/ which I'm going to leave as it makes
> sense to keep the theme code together until we figure out what to do with it.
> All other fwl/ directories have been either removed or merged into core/.

Ok, LGTM, but I'm still not a big fan of having both files and subdirectories at
the same level.  Maybe theme gets folded in?

[dsinclair, 2016-12-08 18:05:25]

On 2016/12/08 18:02:25, Tom Sepez wrote:
> On 2016/12/08 17:49:15, dsinclair wrote:
> > On 2016/12/08 17:41:47, Tom Sepez wrote:
> > > On 2016/12/08 14:42:57, dsinclair wrote:
> > > > PTAL. This is all mechanical file moves except for the Evt -> Event and
> Msg
> > ->
> > > > Message change. I went with EventFoo and MessageFoo because it makes
> working
> > > > with the source a lot simpler as the files all end up grouped. I think
> they
> > > > still read fine in this order.
> > > 
> > > Similar changes planned for other xfa/fwl/... subdirectories?
> > 
> > 
> > The only other fwl directory is theme/ which I'm going to leave as it makes
> > sense to keep the theme code together until we figure out what to do with
it.
> > All other fwl/ directories have been either removed or merged into core/.
> 
> Ok, LGTM, but I'm still not a big fan of having both files and subdirectories
at
> the same level.  Maybe theme gets folded in?


I'm hoping theme/ will go away in the long run but I haven't taken a good look
at what it's doing to determine if that's feasible.

[dsinclair, 2016-12-08 18:05:37]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:05:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 18:06:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481220337356340, "parent_rev":
"64f4e25304dfd93651ac5c9d5379ed2fffbb993f", "commit_rev":
"447b1f3ffc7e0df233d15300bbf8a85ce2bc7278"}

[commit-bot: I haz the power, 2016-12-08 18:06:38]

Description was changed from

==========
Move xfa/fwl/core to xfa/fwl.

The core/ directory in FWL no-longer provides any context. This Cl moves all
of the core/ files up to the fwl/ folder.

As well, the CFWL_EvtFoo files are renamed CFWL_EventFoo and the CFWL_MsgFoo
files are renamed CFWL_MessageFoo. The event and message preceed the type in
order to keep the files sorted together and to make it clear that they're all
related.
==========

to

==========
Move xfa/fwl/core to xfa/fwl.

The core/ directory in FWL no-longer provides any context. This Cl moves all
of the core/ files up to the fwl/ folder.

As well, the CFWL_EvtFoo files are renamed CFWL_EventFoo and the CFWL_MsgFoo
files are renamed CFWL_MessageFoo. The event and message preceed the type in
order to keep the files sorted together and to make it clear that they're all
related.

Committed:
https://pdfium.googlesource.com/pdfium/+/447b1f3ffc7e0df233d15300bbf8a85ce2bc...
==========

[commit-bot: I haz the power, 2016-12-08 18:06:39]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/447b1f3ffc7e0df233d15300bbf8a85ce2bc...