Cleanup CFWL_Widget code to return CFX_RectFs where appropriate

xfa/fwl/cfwl_listbox.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/cfwl_listbox.h"
 
 #include <algorithm>
 #include <memory>
@@ skipping 367 matching lines @@
     bScroll = true;
   } else if (rtItem.bottom() > m_rtConent.bottom()) {
     fPosY += rtItem.bottom() - m_rtConent.bottom();
     bScroll = true;
   }
   if (!bScroll)
     return false;
 
   m_pVertScrollBar->SetPos(fPosY);
   m_pVertScrollBar->SetTrackPos(fPosY);
-  Repaint(&m_rtClient);
+  RepaintRect(m_rtClient);
   return true;
 }
 
 void CFWL_ListBox::DrawBkground(CFX_Graphics* pGraphics,
                                 IFWL_ThemeProvider* pTheme,
                                 const CFX_Matrix* pMatrix) {
   if (!pGraphics)
     return;
   if (!pTheme)
     return;
@@ skipping 148 matching lines @@
   textParam.m_iTTOAlign = m_iTTOAligns;
   textParam.m_bMaximize = true;
   pTheme->DrawText(&textParam);
 }
 
 CFX_SizeF CFWL_ListBox::CalcSize(bool bAutoSize) {
   CFX_SizeF fs;
   if (!m_pProperties->m_pThemeProvider)
     return fs;
 
-  GetClientRect(m_rtClient);
+  m_rtClient = GetClientRect();
   m_rtConent = m_rtClient;
   CFX_RectF rtUIMargin;
   rtUIMargin.Set(0, 0, 0, 0);
   if (!m_pOuter) {
     CFX_RectF* pUIMargin = static_cast<CFX_RectF*>(
         GetThemeCapacity(CFWL_WidgetCapacity::UIMargin));
     if (pUIMargin) {
       m_rtConent.Deflate(pUIMargin->left, pUIMargin->top, pUIMargin->width,
                          pUIMargin->height);
     }
@@ skipping 266 matching lines @@
         m_pHorzScrollBar->RemoveStates(FWL_WGTSTATE_Invisible);
       else
         m_pHorzScrollBar->SetStates(FWL_WGTSTATE_Invisible);
     }
   }
   if (bSet)
     m_pProperties->m_dwStates |= (FWL_WGTSTATE_Focused);
   else
     m_pProperties->m_dwStates &= ~(FWL_WGTSTATE_Focused);
 
-  Repaint(&m_rtClient);
+  RepaintRect(m_rtClient);
 }
 
 void CFWL_ListBox::OnLButtonDown(CFWL_MessageMouse* pMsg) {
   m_bLButtonDown = true;
   if ((m_pProperties->m_dwStates & FWL_WGTSTATE_Focused) == 0)
     SetFocus(true);
 
   CFWL_ListItem* pItem = GetItemAtPoint(pMsg->m_fx, pMsg->m_fy);
   if (!pItem)
     return;
@@ skipping 21 matching lines @@
     GetItemCheckRectInternal(hSelectedItem, rtCheck);
     bool bChecked = GetItemChecked(pItem);
     if (rtCheck.Contains(pMsg->m_fx, pMsg->m_fy)) {
       SetItemChecked(pItem, !bChecked);
       Update();
     }
   }
   SetFocusItem(pItem);
   ScrollToVisible(pItem);
   SetGrab(true);
-  Repaint(&m_rtClient);
+  RepaintRect(m_rtClient);
 }
 
 void CFWL_ListBox::OnLButtonUp(CFWL_MessageMouse* pMsg) {
   if (!m_bLButtonDown)
     return;
 
   m_bLButtonDown = false;
   SetGrab(false);
 }
 
@@ skipping 41 matching lines @@
   } else {
     SetSelection(pItem, pItem, true);
   }
 
   SetFocusItem(pItem);
   ScrollToVisible(pItem);
 
   CFX_RectF rtInvalidate;
   rtInvalidate.Set(0, 0, m_pProperties->m_rtWidget.width,
                    m_pProperties->m_rtWidget.height);
-  Repaint(&rtInvalidate);
+  RepaintRect(rtInvalidate);
 }
 
 bool CFWL_ListBox::OnScroll(CFWL_ScrollBar* pScrollBar,
                             CFWL_EventScroll::Code dwCode,
                             FX_FLOAT fPos) {
   CFX_SizeF fs;
   pScrollBar->GetRange(&fs.x, &fs.y);
   FX_FLOAT iCurPos = pScrollBar->GetPos();
   FX_FLOAT fStep = pScrollBar->GetStepSize();
   switch (dwCode) {
@@ skipping 32 matching lines @@
     case CFWL_EventScroll::Code::Pos:
     case CFWL_EventScroll::Code::TrackPos:
     case CFWL_EventScroll::Code::None:
       break;
     case CFWL_EventScroll::Code::EndScroll:
       return false;
   }
   if (iCurPos != fPos) {
     pScrollBar->SetPos(fPos);
     pScrollBar->SetTrackPos(fPos);
-    Repaint(&m_rtClient);
+    RepaintRect(m_rtClient);
   }
   return true;
 }
 
 CFX_WideString CFWL_ListBox::GetItemText(CFWL_Widget* pWidget,
                                          CFWL_ListItem* pItem) {
   return pItem ? static_cast<CFWL_ListItem*>(pItem)->m_wsText : L"";
 }
 
 int32_t CFWL_ListBox::CountItems(const CFWL_Widget* pWidget) const {
@@ skipping 109 matching lines @@
 
 void CFWL_ListBox::DeleteAll() {
   m_ItemArray.clear();
 }
 
 uint32_t CFWL_ListBox::GetItemStates(CFWL_ListItem* pItem) {
   if (!pItem)
     return 0;
   return pItem->m_dwStates | pItem->m_dwCheckState;
 }