Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp

Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp

Now tests in MemoryCacheCorrectnessTest.cpp use ImageResource for
testing, but ImageResource will be moved to core/loader/resource/, and
core/fetch should not have a dependency to the core/loader/.

This patch makes tests in MemoryCacheCorrectnessTest.cpp use
MockResource to remove a dependency to the ImageResource.

BUG=655920
TEST=webkit_unit_tests --gtest_filer='MemoryCacheCorrectnessTest.*'

Committed: https://crrev.com/f19805a9187b34d8368ada79091c9980c7d83fb2
Cr-Commit-Position: refs/heads/master@{#438466}

[Takashi Toyoshima, 2016-12-07 12:08:11]

Description was changed from

==========
Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp

Now tests in MemoryCacheCorrectnessTest.cpp use ImageResource for
testing, but ImageResource will be moved to core/loader/resource/, and
core/fetch should not have a dependency to the core/loader/.

This patch makes tests in MemoryCacheCorrectnessTest.cpp use
MockResource to remove a dependency to the ImageResource.

BUG=655920
TEST=webkit_unit_tests --gtest_filer='MemoryCacheCorrectnessTest.*'
==========

to

==========
Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp

Now tests in MemoryCacheCorrectnessTest.cpp use ImageResource for
testing, but ImageResource will be moved to core/loader/resource/, and
core/fetch should not have a dependency to the core/loader/.

This patch makes tests in MemoryCacheCorrectnessTest.cpp use
MockResource to remove a dependency to the ImageResource.

BUG=655920
TEST=webkit_unit_tests --gtest_filer='MemoryCacheCorrectnessTest.*'
==========

[Takashi Toyoshima, 2016-12-07 12:08:11]

toyoshim@chromium.org changed reviewers:
+ hiroshige@chromium.org, yhirano@chromium.org

[Takashi Toyoshima, 2016-12-07 12:08:18]

ptal

[yhirano, 2016-12-13 02:27:48]

lgtm

[hiroshige, 2016-12-13 08:56:46]

MemoryCacheCorrectnessTestHelper::resourceFromResourceResponse() contains |if
(type == Image)| block (Lines 43--47) that is no longer needed and we can remove
it.

https://codereview.chromium.org/2560763002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp
(right):

https://codereview.chromium.org/2560763002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp:45:
Resource* fetchImage() {
nit: now it doesn't fetch an image, so renaming might be preferable.

https://codereview.chromium.org/2560763002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp:56: case
Resource::Raw:
According to the concept of MockResource, probably we can (or should) also use
MockResource instead of RawResource here, and hence we can remove |type|
argument of createResource().
I think it should be handled in a separate CL, to keep this CL only removing
ImageResource dependency.

[Takashi Toyoshima, 2016-12-13 12:52:19]

https://codereview.chromium.org/2560763002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp
(right):

https://codereview.chromium.org/2560763002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp:45:
Resource* fetchImage() {
On 2016/12/13 08:56:45, hiroshige wrote:
> nit: now it doesn't fetch an image, so renaming might be preferable.

Done.

https://codereview.chromium.org/2560763002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp:56: case
Resource::Raw:
Yes, that's in my plan. I'll leave a TODO here.

Some tests have the same test for both RawResource and ImageResource. So, I need
to clarify what should be verified for each, and may need to use pseudo Raw type
instead of Mock.

[hiroshige, 2016-12-13 17:25:47]

lgtm.

[Takashi Toyoshima, 2016-12-14 05:39:18]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 05:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 07:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 07:38:23]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2016-12-14 08:53:29]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-12-14 08:53:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
yhirano@chromium.org, hiroshige@chromium.org
Link to the patchset: https://codereview.chromium.org/2560763002/#ps60001
(title: "[rebase]")

[commit-bot: I haz the power, 2016-12-14 08:53:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 08:58:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481705609333520,
"parent_rev": "45be5e9f18e516b983270395aab059af6af3602f", "commit_rev":
"1e9b95c033affb518d934af3a852a3bcaaf91891"}

[commit-bot: I haz the power, 2016-12-14 08:58:33]

Description was changed from

==========
Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp

Now tests in MemoryCacheCorrectnessTest.cpp use ImageResource for
testing, but ImageResource will be moved to core/loader/resource/, and
core/fetch should not have a dependency to the core/loader/.

This patch makes tests in MemoryCacheCorrectnessTest.cpp use
MockResource to remove a dependency to the ImageResource.

BUG=655920
TEST=webkit_unit_tests --gtest_filer='MemoryCacheCorrectnessTest.*'
==========

to

==========
Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp

Now tests in MemoryCacheCorrectnessTest.cpp use ImageResource for
testing, but ImageResource will be moved to core/loader/resource/, and
core/fetch should not have a dependency to the core/loader/.

This patch makes tests in MemoryCacheCorrectnessTest.cpp use
MockResource to remove a dependency to the ImageResource.

BUG=655920
TEST=webkit_unit_tests --gtest_filer='MemoryCacheCorrectnessTest.*'

Review-Url: https://codereview.chromium.org/2560763002
==========

[commit-bot: I haz the power, 2016-12-14 08:58:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 09:00:30]

Description was changed from

==========
Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp

Now tests in MemoryCacheCorrectnessTest.cpp use ImageResource for
testing, but ImageResource will be moved to core/loader/resource/, and
core/fetch should not have a dependency to the core/loader/.

This patch makes tests in MemoryCacheCorrectnessTest.cpp use
MockResource to remove a dependency to the ImageResource.

BUG=655920
TEST=webkit_unit_tests --gtest_filer='MemoryCacheCorrectnessTest.*'

Review-Url: https://codereview.chromium.org/2560763002
==========

to

==========
Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp

Now tests in MemoryCacheCorrectnessTest.cpp use ImageResource for
testing, but ImageResource will be moved to core/loader/resource/, and
core/fetch should not have a dependency to the core/loader/.

This patch makes tests in MemoryCacheCorrectnessTest.cpp use
MockResource to remove a dependency to the ImageResource.

BUG=655920
TEST=webkit_unit_tests --gtest_filer='MemoryCacheCorrectnessTest.*'

Committed: https://crrev.com/f19805a9187b34d8368ada79091c9980c7d83fb2
Cr-Commit-Position: refs/heads/master@{#438466}
==========

[commit-bot: I haz the power, 2016-12-14 09:00:32]

Patchset 4 (id:??) landed as
https://crrev.com/f19805a9187b34d8368ada79091c9980c7d83fb2
Cr-Commit-Position: refs/heads/master@{#438466}