third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp - Issue 2560763002: Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp

Issue 2560763002: Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp (Closed)

Patch Set: [rebase] Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp ('k') | third_party/WebKit/Source/core/fetch/MockResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp

diff --git a/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp b/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp

index 800335311d22e319954a44d4e336561372bbd62b..bf0d022a8583c65e3b5f52f20503208d04362971 100644

--- a/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp

+++ b/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp

@@ -40,11 +40,6 @@ Resource* MemoryCacheCorrectnessTestHelper::resourceFromResourceResponse(

Resource* resource = createResource(ResourceRequest(response.url()), type);

resource->setResponse(response);

resource->finish();

- // Because we didn't give any real data, an image will have set its status

- // to DecodeError. Override it so the resource is cacaheable for testing

- // purposes.

- if (type == Resource::Image)

- resource->setStatus(Resource::Cached);

memoryCache()->add(resource);

return resource;