Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2558033002: Loading: move ImageResource and related classes to core/loader/resource (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, dshwang, eae+blinkwatch, fs, dcheng, apavlov+blink_chromium.org, kouhei+svg_chromium.org, rwlbuis, Yoav Weiss, krit, blink-reviews-css, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, Navid Zolghadr, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, loading-reviews_chromium.org, darktears, loading-reviews+fetch_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, dtapuska+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, f(malita), Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: move ImageResource and related classes to core/loader/resource To move core/dependency so that core/fetch can be moved under platform, move ImageResource, ImageResourceClient, and related classes to core/loader/resource/. After this patch, all dependencies from core/fetch to core/ will be removed, and core/fetch gets ready to be moved under platform. BUG=655920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68 Cr-Commit-Position: refs/heads/master@{#438468}

Patch Set 1 #

Patch Set 2 : rebase and format #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -3579 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 1 chunk +0 lines, -4 lines 1 comment Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageSetValue.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSStyleImageValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ImageResource.h View 1 1 chunk +0 lines, -168 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 1 chunk +0 lines, -511 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ImageResourceContent.h View 1 1 chunk +0 lines, -164 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ImageResourceContent.cpp View 1 1 chunk +0 lines, -475 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ImageResourceInfo.h View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ImageResourceObserver.h View 1 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 1 1 chunk +0 lines, -1217 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/MockImageResourceClient.h View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/MockImageResourceClient.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h View 1 chunk +0 lines, -102 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp View 1 chunk +0 lines, -187 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp View 1 chunk +0 lines, -429 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/BUILD.gn View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/ImageResource.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/ImageResource.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/ImageResourceContent.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp View 1 2 chunks +8 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/ImageResourceObserver.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp View 1 4 chunks +8 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/MockImageResourceClient.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/MockImageResourceClient.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParser.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParserTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ShapeValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEImageElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (14 generated)
Takashi Toyoshima
ptal. This is the last one that I want to submit just after the hiroshige's ...
4 years ago (2016-12-07 12:43:42 UTC) #4
hiroshige
lgtm.
4 years ago (2016-12-12 14:39:27 UTC) #5
kouhei (in TOK)
lgtm
4 years ago (2016-12-13 00:02:33 UTC) #7
Takashi Toyoshima
+haraken for modules/
4 years ago (2016-12-14 06:06:55 UTC) #9
haraken
LGTM
4 years ago (2016-12-14 06:11:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558033002/20001
4 years ago (2016-12-14 09:03:57 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 09:09:53 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68 Cr-Commit-Position: refs/heads/master@{#438468}
4 years ago (2016-12-14 09:12:00 UTC) #22
hiroshige
4 years ago (2016-12-16 20:44:24 UTC) #23
Message was sent while issue was closed.
https://codereview.chromium.org/2558033002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/BUILD.gn (left):

https://codereview.chromium.org/2558033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/BUILD.gn:1108: "fetch/ImageResourceTest.cpp",
I've just noticed that we shouldn't have removed these lines, but instead we
should have renamed these.
Removing these lines is causing ImageResourceTest is not compiled and executed.
I created resurrect them:
https://codereview.chromium.org/2577073004/.

Powered by Google App Engine
This is Rietveld 408576698