Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 2560643002: Remove ios conditionals in chrome/app/*.grd (Closed)

Created:
4 years ago by brettw
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ios conditionals in chrome/app/*.grd The iOS build does not depend on these any more. Committed: https://crrev.com/bef56de6db296e3b789b2a336ddf5dea4a68be57 Cr-Commit-Position: refs/heads/master@{#436963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -199 lines) Patch
M chrome/app/address_input_strings.grd View 2 chunks +2 lines, -14 lines 0 comments Download
M chrome/app/chromium_strings.grd View 6 chunks +6 lines, -24 lines 0 comments Download
M chrome/app/generated_resources.grd View 18 chunks +95 lines, -138 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 5 chunks +5 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
brettw
4 years ago (2016-12-07 00:16:30 UTC) #4
sdefresne
lgtm thank you for the cleanup
4 years ago (2016-12-07 11:06:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560643002/1
4 years ago (2016-12-07 15:37:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 15:47:27 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 15:49:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bef56de6db296e3b789b2a336ddf5dea4a68be57
Cr-Commit-Position: refs/heads/master@{#436963}

Powered by Google App Engine
This is Rietveld 408576698