Remove enable_notifications build flag and define

Remove enable_notifications build flag and define

This flag is not overridable and is set everywhere except iOS. All users except
one are in //chrome which isn't compiled on iOS. So in all of these cases we
can remove the conditionals and always compile the code.

For the one case in ui, The conditional is replaced with !is_ios. This was also
done with the .grd file in chrome. This file has a lot of iOS conditionals and
I want to be sure it's not needed on iOS before inlining them unconditionally.
Then we can delete all of the iOS conditionals.

BUG=671706
Committed: https://crrev.com/1f92eed58cef4d29db962d41d1055935d4cd2f59
Cr-Commit-Position: refs/heads/master@{#436813}

[brettw, 2016-12-06 19:01:49]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[brettw, 2016-12-06 19:01:54]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 19:02:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2016-12-06 19:07:10]

peter@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2016-12-06 19:07:10]

lgtm \o/ thank you for cleaning this up!

[brettw, 2016-12-06 20:09:46]

Description was changed from

==========
Remove enable_notifications build flag and define

This flag is not overridable and is set everywhere except iOS. All users except
one are in //chrome which isn't compiled on iOS. So in all of these cases we
can remove the conditionals and always compile the code.

For the one case in ui, The conditional is replaced with !is_ios. This was also
done with the .grd file in chrome. This file has a lot of iOS conditionals and
I want to be sure it's not needed on iOS before inlining them unconditionally.
Then we can delete all of the iOS conditionals.

BUG=671706
==========

to

==========
Remove enable_notifications build flag and define

This flag is not overridable and is set everywhere except iOS. All users except
one are in //chrome which isn't compiled on iOS. So in all of these cases we
can remove the conditionals and always compile the code.

For the one case in ui, The conditional is replaced with !is_ios. This was also
done with the .grd file in chrome. This file has a lot of iOS conditionals and
I want to be sure it's not needed on iOS before inlining them unconditionally.
Then we can delete all of the iOS conditionals.

BUG=671706
==========

[brettw, 2016-12-06 20:09:46]

brettw@chromium.org changed reviewers:
- sky@chromium.org

[brettw, 2016-12-06 20:10:09]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-12-06 20:10:11]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-12-06 20:11:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 21:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:03:25]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[brettw, 2016-12-06 21:10:05]

Merge

[brettw, 2016-12-06 21:10:15]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-12-06 21:10:16]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2555833002/#ps20001
(title: "Merge")

[commit-bot: I haz the power, 2016-12-06 21:10:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 01:13:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481058615781360,
"parent_rev": "98a74fe680c70bace9aa05cf7e8c24442f186e87", "commit_rev":
"888c83278c21308c60dbe2bf64bac23e2ab13c72"}

[commit-bot: I haz the power, 2016-12-07 01:13:27]

Description was changed from

==========
Remove enable_notifications build flag and define

This flag is not overridable and is set everywhere except iOS. All users except
one are in //chrome which isn't compiled on iOS. So in all of these cases we
can remove the conditionals and always compile the code.

For the one case in ui, The conditional is replaced with !is_ios. This was also
done with the .grd file in chrome. This file has a lot of iOS conditionals and
I want to be sure it's not needed on iOS before inlining them unconditionally.
Then we can delete all of the iOS conditionals.

BUG=671706
==========

to

==========
Remove enable_notifications build flag and define

This flag is not overridable and is set everywhere except iOS. All users except
one are in //chrome which isn't compiled on iOS. So in all of these cases we
can remove the conditionals and always compile the code.

For the one case in ui, The conditional is replaced with !is_ios. This was also
done with the .grd file in chrome. This file has a lot of iOS conditionals and
I want to be sure it's not needed on iOS before inlining them unconditionally.
Then we can delete all of the iOS conditionals.

BUG=671706
==========

[commit-bot: I haz the power, 2016-12-07 01:13:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 01:16:15]

Description was changed from

==========
Remove enable_notifications build flag and define

This flag is not overridable and is set everywhere except iOS. All users except
one are in //chrome which isn't compiled on iOS. So in all of these cases we
can remove the conditionals and always compile the code.

For the one case in ui, The conditional is replaced with !is_ios. This was also
done with the .grd file in chrome. This file has a lot of iOS conditionals and
I want to be sure it's not needed on iOS before inlining them unconditionally.
Then we can delete all of the iOS conditionals.

BUG=671706
==========

to

==========
Remove enable_notifications build flag and define

This flag is not overridable and is set everywhere except iOS. All users except
one are in //chrome which isn't compiled on iOS. So in all of these cases we
can remove the conditionals and always compile the code.

For the one case in ui, The conditional is replaced with !is_ios. This was also
done with the .grd file in chrome. This file has a lot of iOS conditionals and
I want to be sure it's not needed on iOS before inlining them unconditionally.
Then we can delete all of the iOS conditionals.

BUG=671706

Committed: https://crrev.com/1f92eed58cef4d29db962d41d1055935d4cd2f59
Cr-Commit-Position: refs/heads/master@{#436813}
==========

[commit-bot: I haz the power, 2016-12-07 01:16:16]

Patchset 2 (id:??) landed as
https://crrev.com/1f92eed58cef4d29db962d41d1055935d4cd2f59
Cr-Commit-Position: refs/heads/master@{#436813}