Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2559343003: mus: Rename GpuService to Gpu. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Rename GpuService to Gpu. BUG=none TBR=ben@ for content/renderer Committed: https://crrev.com/04cfa89ab78efc7897bccc73b8b50e1dfe0d950c Cr-Commit-Position: refs/heads/master@{#437583}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -426 lines) Patch
M ash/mus/window_manager_application.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/window_manager_application.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download
M mash/simple_wm/simple_wm.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mash/simple_wm/simple_wm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/sync_call_restrictions.h View 2 chunks +2 lines, -7 lines 0 comments Download
M services/ui/demo/mus_demo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M services/ui/gpu/gpu_main.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/manifest.json View 3 chunks +1 line, -4 lines 0 comments Download
M services/ui/public/cpp/gpu/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h View 1 3 chunks +4 lines, -8 lines 0 comments Download
M services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc View 1 4 chunks +9 lines, -11 lines 0 comments Download
A + services/ui/public/cpp/gpu/gpu.h View 1 5 chunks +14 lines, -14 lines 0 comments Download
A + services/ui/public/cpp/gpu/gpu.cc View 1 9 chunks +19 lines, -22 lines 0 comments Download
D services/ui/public/cpp/gpu/gpu_service.h View 1 1 chunk +0 lines, -82 lines 0 comments Download
D services/ui/public/cpp/gpu/gpu_service.cc View 1 1 chunk +0 lines, -156 lines 0 comments Download
M services/ui/public/interfaces/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + services/ui/public/interfaces/gpu.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/interfaces/gpu_service.mojom View 1 1 chunk +0 lines, -31 lines 0 comments Download
M services/ui/service.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M services/ui/service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/test_wm/test_wm.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M services/ui/ws/window_server_test_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/window_server_test_base.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/mus/mus_context_factory.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/mus/mus_context_factory.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ui/views/mus/mus_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/mus_client.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/mus/surface_context_factory.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (12 generated)
sadrul
As discussed on the list. This is part 1/2.
4 years ago (2016-12-09 03:58:10 UTC) #4
sadrul
+tsepez@ for mojom changes
4 years ago (2016-12-09 03:59:22 UTC) #6
sky
Rubber stamp LGTM
4 years ago (2016-12-09 16:03:46 UTC) #9
Tom Sepez
RS LGTM
4 years ago (2016-12-09 17:13:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559343003/20001
4 years ago (2016-12-09 17:42:54 UTC) #12
sadrul
+ben@ for content/ (will TBR)
4 years ago (2016-12-09 17:45:25 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 17:54:27 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 14:36:07 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04cfa89ab78efc7897bccc73b8b50e1dfe0d950c
Cr-Commit-Position: refs/heads/master@{#437583}

Powered by Google App Engine
This is Rietveld 408576698