Add support for generating PkgInfo for application bundle on iOS.

Add support for generating PkgInfo for application bundle on iOS.

The generation of PkgInfo is disabled for the moment (as come target
downstream already pack a PkgInfo file and enabling the target would
cause a non-deterministic build) and can be enabled by an undocumented
parameter write_pkg_info.

Update build/config/mac/write_pkg_info.py to support loading plist
in any format, not only xml1.

BUG=672516
Committed: https://crrev.com/8afe7bf6abf4c6c50b9c8f153e4ebf3cb045ef83
Cr-Commit-Position: refs/heads/master@{#437551}

[sdefresne, 2016-12-09 11:47:09]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 11:47:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-09 11:47:44]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org, rsesek@chromium.org

[sdefresne, 2016-12-09 11:47:44]

Please both take a look.

rohitrao: look at iOS templates
rsesek: look at build/config/mac/write_pkg_info.py

[sdefresne, 2016-12-09 11:54:50]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-12-09 11:55:02]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-12-09 11:55:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2016-12-09 12:14:42]

lgtm

https://codereview.chromium.org/2559323005/diff/20001/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/2559323005/diff/20001/build/config/ios/rules....
build/config/ios/rules.gni:655: "$target_gen_dir/$target_name",
Why is the output of this step not a file named PkgInfo?

[commit-bot: I haz the power, 2016-12-09 12:52:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 12:52:37]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-12-09 13:50:19]

https://codereview.chromium.org/2559323005/diff/20001/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/2559323005/diff/20001/build/config/ios/rules....
build/config/ios/rules.gni:655: "$target_gen_dir/$target_name",
On 2016/12/09 12:14:42, rohitrao wrote:
> Why is the output of this step not a file named PkgInfo?

$target_gen_dir does not depends on the current target name (only on the path to
the BUILD.gn file containing the target). It means that if two separate target
in the same BUILD.gn file use the ios_app_bundle target, they will both try to
generate the same file named PkgInfo.

If I change the line to "$target_gen_dir/PkfInfo", I get the following error
while running "gn gen":

Two or more targets generate the same output:
  gen/base/PkgInfo

This is can often be fixed by changing one of the target names, or by 
setting an output_name on one of them.

Collisions:
  //base:base_i18n_perftests_pkg_info
  //base:base_perftests_pkg_info
  //base:base_unittests_pkg_info

Since the target _bundle_data_pkg_info rename the file to PkgInfo while copying
to the bundle, there is not really a need to name the file PkgInfo while
creating it. If you really care about that, I can change this to
"$target_gen_dir/$target_name/PkgInfo" though.

[rohitrao (ping after 24h), 2016-12-09 13:51:51]

https://codereview.chromium.org/2559323005/diff/20001/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/2559323005/diff/20001/build/config/ios/rules....
build/config/ios/rules.gni:655: "$target_gen_dir/$target_name",
>  If you really care about that, I can change this to
> "$target_gen_dir/$target_name/PkgInfo" though.

Nope, it was just unexpected.  Perhaps summarize what you just wrote into a
short comment?

[sdefresne, 2016-12-09 14:55:47]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-12-09 14:55:56]

On 2016/12/09 13:51:51, rohitrao wrote:
>
https://codereview.chromium.org/2559323005/diff/20001/build/config/ios/rules.gni
> File build/config/ios/rules.gni (right):
> 
>
https://codereview.chromium.org/2559323005/diff/20001/build/config/ios/rules....
> build/config/ios/rules.gni:655: "$target_gen_dir/$target_name",
> >  If you really care about that, I can change this to
> > "$target_gen_dir/$target_name/PkgInfo" though.
> 
> Nope, it was just unexpected.  Perhaps summarize what you just wrote into a
> short comment?

Done in patchset #2. Sending to CQ.

[commit-bot: I haz the power, 2016-12-09 14:56:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-09 14:56:03]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-12-09 14:56:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2559323005/#ps40001
(title: "Add a comment to explain why the intermediate file is not named
PkfInfo.")

[commit-bot: I haz the power, 2016-12-09 14:56:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-12-09 15:55:08]

Huh, didn't realize iOS had PkgInfo files, since they're basically deprecated on
Mac.

LGTM

https://codereview.chromium.org/2559323005/diff/40001/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/2559323005/diff/40001/build/config/ios/rules....
build/config/ios/rules.gni:414: #
Document write_pkg_info ?

https://codereview.chromium.org/2559323005/diff/40001/build/config/ios/rules....
build/config/ios/rules.gni:432: "prevents 'Assignment had no effect.' errors")
🙄

https://codereview.chromium.org/2559323005/diff/40001/build/config/mac/write_...
File build/config/mac/write_pkg_info.py (right):

https://codereview.chromium.org/2559323005/diff/40001/build/config/mac/write_...
build/config/mac/write_pkg_info.py:31: ('AAPL', package_type))
I made a typo here but if it's already in the CQ, it's fine to not fix :p.

[sdefresne, 2016-12-09 16:03:06]

https://codereview.chromium.org/2559323005/diff/40001/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/2559323005/diff/40001/build/config/ios/rules....
build/config/ios/rules.gni:414: #
On 2016/12/09 15:55:08, Robert Sesek wrote:
> Document write_pkg_info ?

It will be removed in three CLs. It is undocumented on purpose :-)

https://codereview.chromium.org/2559323005/diff/40001/build/config/ios/rules....
build/config/ios/rules.gni:432: "prevents 'Assignment had no effect.' errors")
On 2016/12/09 15:55:07, Robert Sesek wrote:
> 🙄

I know.

https://codereview.chromium.org/2559323005/diff/40001/build/config/mac/write_...
File build/config/mac/write_pkg_info.py (right):

https://codereview.chromium.org/2559323005/diff/40001/build/config/mac/write_...
build/config/mac/write_pkg_info.py:31: ('AAPL', package_type))
On 2016/12/09 15:55:08, Robert Sesek wrote:
> I made a typo here but if it's already in the CQ, it's fine to not fix :p.

Will do in a followup :-)

[commit-bot: I haz the power, 2016-12-09 16:06:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481295363114220,
"parent_rev": "b03d20405ff88f6f5354693cdb4b8d55bdb9bb30", "commit_rev":
"419df0e9daa0617dd28a8d0ca9c94f67f0f0372f"}

[commit-bot: I haz the power, 2016-12-09 16:06:30]

Description was changed from

==========
Add support for generating PkgInfo for application bundle on iOS.

The generation of PkgInfo is disabled for the moment (as come target
downstream already pack a PkgInfo file and enabling the target would
cause a non-deterministic build) and can be enabled by an undocumented
parameter write_pkg_info.

Update build/config/mac/write_pkg_info.py to support loading plist
in any format, not only xml1.

BUG=672516
==========

to

==========
Add support for generating PkgInfo for application bundle on iOS.

The generation of PkgInfo is disabled for the moment (as come target
downstream already pack a PkgInfo file and enabling the target would
cause a non-deterministic build) and can be enabled by an undocumented
parameter write_pkg_info.

Update build/config/mac/write_pkg_info.py to support loading plist
in any format, not only xml1.

BUG=672516

Review-Url: https://codereview.chromium.org/2559323005
==========

[commit-bot: I haz the power, 2016-12-09 16:06:31]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-12-09 16:08:38]

Description was changed from

==========
Add support for generating PkgInfo for application bundle on iOS.

The generation of PkgInfo is disabled for the moment (as come target
downstream already pack a PkgInfo file and enabling the target would
cause a non-deterministic build) and can be enabled by an undocumented
parameter write_pkg_info.

Update build/config/mac/write_pkg_info.py to support loading plist
in any format, not only xml1.

BUG=672516

Review-Url: https://codereview.chromium.org/2559323005
==========

to

==========
Add support for generating PkgInfo for application bundle on iOS.

The generation of PkgInfo is disabled for the moment (as come target
downstream already pack a PkgInfo file and enabling the target would
cause a non-deterministic build) and can be enabled by an undocumented
parameter write_pkg_info.

Update build/config/mac/write_pkg_info.py to support loading plist
in any format, not only xml1.

BUG=672516

Committed: https://crrev.com/8afe7bf6abf4c6c50b9c8f153e4ebf3cb045ef83
Cr-Commit-Position: refs/heads/master@{#437551}
==========

[commit-bot: I haz the power, 2016-12-09 16:08:40]

Patchset 2 (id:??) landed as
https://crrev.com/8afe7bf6abf4c6c50b9c8f153e4ebf3cb045ef83
Cr-Commit-Position: refs/heads/master@{#437551}