Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2557393002: Add dependency on :settings_resources. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dependency on :settings_resources. As the downstream code has been updated to use the upstream version of the resources (and there is no risk of multiple targets creating the same file in the application bundle), add the dependency to the :settings_resources upstream. BUG=672516 Committed: https://crrev.com/ae441047798d64bb8bddf194166e76b6c915abe8 Cr-Commit-Position: refs/heads/master@{#437525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
sdefresne
Please take a look.
4 years ago (2016-12-08 16:55:59 UTC) #3
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-08 17:01:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557393002/1
4 years ago (2016-12-09 13:20:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 13:25:02 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-09 13:27:20 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae441047798d64bb8bddf194166e76b6c915abe8
Cr-Commit-Position: refs/heads/master@{#437525}

Powered by Google App Engine
This is Rietveld 408576698