[inspector] Store interger in context embedder data instead of a string.

[inspector] Store interger in context embedder data instead of a string.

This is to improve the performance of common operation of
extracting contextId or contextGroupId out of Context.

BUG=none

Committed: https://crrev.com/2bdd0feb776508f79b7b28f9c6c8e4653a3f96e7
Cr-Commit-Position: refs/heads/master@{#41657}

[dgozman, 2016-12-08 23:31:57]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 23:32:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-12-08 23:34:28]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, yangguo@chromium.org

[dgozman, 2016-12-08 23:34:28]

Could you please take a look?

[commit-bot: I haz the power, 2016-12-09 00:10:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 00:10:11]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-12-09 00:24:27]

lgtm

https://codereview.chromium.org/2558913004/diff/1/src/inspector/v8-debugger-a...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2558913004/diff/1/src/inspector/v8-debugger-a...
src/inspector/v8-debugger-agent-impl.cc:1058: if (inspected) {
Could you put comment here that script can contain stale executionContextId
here?

https://codereview.chromium.org/2558913004/diff/1/src/inspector/v8-debugger.cc
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2558913004/diff/1/src/inspector/v8-debugger.c...
src/inspector/v8-debugger.cc:101: int contextId =
static_cast<int>(v8::Int32::Cast(*contextData)->Value());
contextData.As<v8::Int32>()->Value()
or
v8::Local<v8::Int32>::Cast(contextData)->Value()

[kozy, 2016-12-09 00:25:13]

https://codereview.chromium.org/2558913004/diff/1/src/inspector/v8-debugger-s...
File src/inspector/v8-debugger-script.cc (right):

https://codereview.chromium.org/2558913004/diff/1/src/inspector/v8-debugger-s...
src/inspector/v8-debugger-script.cc:105:
static_cast<int>(v8::Int32::Cast(*contextData)->Value());
contextData.As<v8::Int32>()->Value()
or
v8::Local<v8::Int32>::Cast(contextData)->Value()

[dgozman, 2016-12-09 22:30:48]

Yang, could you please take a look at debug-interface and api.cc? Thank you!

https://codereview.chromium.org/2558913004/diff/1/src/inspector/v8-debugger-a...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2558913004/diff/1/src/inspector/v8-debugger-a...
src/inspector/v8-debugger-agent-impl.cc:1058: if (inspected) {
On 2016/12/09 00:24:26, kozyatinskiy wrote:
> Could you put comment here that script can contain stale executionContextId
> here?

Done.

https://codereview.chromium.org/2558913004/diff/1/src/inspector/v8-debugger.cc
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2558913004/diff/1/src/inspector/v8-debugger.c...
src/inspector/v8-debugger.cc:101: int contextId =
static_cast<int>(v8::Int32::Cast(*contextData)->Value());
On 2016/12/09 00:24:26, kozyatinskiy wrote:
> contextData.As<v8::Int32>()->Value()
> or
> v8::Local<v8::Int32>::Cast(contextData)->Value()

Done.

[dgozman, 2016-12-09 22:31:19]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 22:31:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 23:05:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 23:05:49]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-12 20:43:05]

dgozman@chromium.org changed reviewers:
+ jochen@chromium.org

[dgozman, 2016-12-12 20:43:05]

+Jochen for OWNER review of debug-interface.h and api.cc.

[Yang, 2016-12-12 20:47:20]

Sorry for the delay. I overlooked this CL. Lgtm.

[dgozman, 2016-12-12 20:48:19]

dgozman@chromium.org changed reviewers:
- jochen@chromium.org

[dgozman, 2016-12-12 20:48:19]

> Sorry for the delay. I overlooked this CL. Lgtm.
Thanks, no worries!

[dgozman, 2016-12-12 20:48:26]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-12-12 20:48:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2558913004/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-12-12 20:48:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 21:16:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481575706736890,
"parent_rev": "ee99fe8f372cbccfafc1d971e4cfb48a613057c2", "commit_rev":
"373766f3f1951b9e70307dce61196dff94cdbca8"}

[commit-bot: I haz the power, 2016-12-12 21:16:26]

Description was changed from

==========
[inspector] Store interger in context embedder data instead of a string.

This is to improve the performance of common operation of
extracting contextId or contextGroupId out of Context.

BUG=none
==========

to

==========
[inspector] Store interger in context embedder data instead of a string.

This is to improve the performance of common operation of
extracting contextId or contextGroupId out of Context.

BUG=none

Review-Url: https://codereview.chromium.org/2558913004
==========

[commit-bot: I haz the power, 2016-12-12 21:16:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 21:17:42]

Description was changed from

==========
[inspector] Store interger in context embedder data instead of a string.

This is to improve the performance of common operation of
extracting contextId or contextGroupId out of Context.

BUG=none

Review-Url: https://codereview.chromium.org/2558913004
==========

to

==========
[inspector] Store interger in context embedder data instead of a string.

This is to improve the performance of common operation of
extracting contextId or contextGroupId out of Context.

BUG=none

Committed: https://crrev.com/2bdd0feb776508f79b7b28f9c6c8e4653a3f96e7
Cr-Commit-Position: refs/heads/master@{#41657}
==========

[commit-bot: I haz the power, 2016-12-12 21:17:43]

Patchset 2 (id:??) landed as
https://crrev.com/2bdd0feb776508f79b7b28f9c6c8e4653a3f96e7
Cr-Commit-Position: refs/heads/master@{#41657}