Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: src/inspector/v8-debugger-script.h

Issue 2558913004: [inspector] Store interger in context embedder data instead of a string. (Closed)
Patch Set: review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.cc ('k') | src/inspector/v8-debugger-script.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 bool hasSourceURL() const { return !m_sourceURL.isEmpty(); } 55 bool hasSourceURL() const { return !m_sourceURL.isEmpty(); }
56 const String16& sourceURL() const; 56 const String16& sourceURL() const;
57 virtual const String16& sourceMappingURL() const = 0; 57 virtual const String16& sourceMappingURL() const = 0;
58 virtual String16 source(v8::Isolate*) const { return m_source; } 58 virtual String16 source(v8::Isolate*) const { return m_source; }
59 const String16& hash(v8::Isolate*) const; 59 const String16& hash(v8::Isolate*) const;
60 int startLine() const { return m_startLine; } 60 int startLine() const { return m_startLine; }
61 int startColumn() const { return m_startColumn; } 61 int startColumn() const { return m_startColumn; }
62 int endLine() const { return m_endLine; } 62 int endLine() const { return m_endLine; }
63 int endColumn() const { return m_endColumn; } 63 int endColumn() const { return m_endColumn; }
64 int executionContextId() const { return m_executionContextId; } 64 int executionContextId() const { return m_executionContextId; }
65 virtual const String16& executionContextAuxData() const = 0;
66 virtual bool isLiveEdit() const = 0; 65 virtual bool isLiveEdit() const = 0;
67 66
68 void setSourceURL(const String16&); 67 void setSourceURL(const String16&);
69 virtual void setSourceMappingURL(const String16&) = 0; 68 virtual void setSourceMappingURL(const String16&) = 0;
70 virtual void setSource(v8::Local<v8::String> source) { 69 virtual void setSource(v8::Local<v8::String> source) {
71 m_source = toProtocolString(source); 70 m_source = toProtocolString(source);
72 } 71 }
73 72
74 virtual bool getPossibleBreakpoints( 73 virtual bool getPossibleBreakpoints(
75 const v8::debug::Location& start, const v8::debug::Location& end, 74 const v8::debug::Location& start, const v8::debug::Location& end,
(...skipping 15 matching lines...) Expand all
91 90
92 v8::Isolate* m_isolate; 91 v8::Isolate* m_isolate;
93 92
94 private: 93 private:
95 DISALLOW_COPY_AND_ASSIGN(V8DebuggerScript); 94 DISALLOW_COPY_AND_ASSIGN(V8DebuggerScript);
96 }; 95 };
97 96
98 } // namespace v8_inspector 97 } // namespace v8_inspector
99 98
100 #endif // V8_INSPECTOR_V8DEBUGGERSCRIPT_H_ 99 #endif // V8_INSPECTOR_V8DEBUGGERSCRIPT_H_
OLDNEW
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.cc ('k') | src/inspector/v8-debugger-script.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698