[inspector] Store interger in context embedder data instead of a string.

src/inspector/v8-debugger-script.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/v8-debugger-script.h"
 
+#include "src/inspector/inspected-context.h"
 #include "src/inspector/string-util.h"
 
 namespace v8_inspector {
 
 namespace {
 
 const char hexDigits[17] = "0123456789ABCDEF";
 
 void appendUnsignedAsHex(uint64_t number, String16Builder* destination) {
   for (size_t i = 0; i < 8; ++i) {
@@ skipping 74 matching lines @@
       if (lineEnds.size() > 1) {
         m_endColumn = source_length - lineEnds[lineEnds.size() - 2] - 1;
       } else {
         m_endColumn = source_length + m_startColumn;
       }
     } else {
       m_endLine = m_startLine;
       m_endColumn = m_startColumn;
     }
 
-    if (script->ContextData().ToLocal(&tmp)) {
-      String16 contextData = toProtocolString(tmp);
-      size_t firstComma = contextData.find(",", 0);
-      size_t secondComma = firstComma != String16::kNotFound
-                               ? contextData.find(",", firstComma + 1)
-                               : String16::kNotFound;
-      if (secondComma != String16::kNotFound) {
-        String16 executionContextId =
-            contextData.substring(firstComma + 1, secondComma - firstComma - 1);
-        bool isOk = false;
-        m_executionContextId = executionContextId.toInteger(&isOk);
-        if (!isOk) m_executionContextId = 0;
-        m_executionContextAuxData = contextData.substring(secondComma + 1);
-      }
+    v8::Local<v8::Value> contextData;
+    if (script->ContextData().ToLocal(&contextData) && contextData->IsInt32()) {
+      m_executionContextId =
+          static_cast<int>(contextData.As<v8::Int32>()->Value());
     }
 
     if (script->Source().ToLocal(&tmp)) {
       m_sourceObj.Reset(m_isolate, tmp);
       String16 source = toProtocolString(tmp);
       // V8 will not count last line if script source ends with \n.
       if (source.length() > 1 && source[source.length() - 1] == '\n') {
         m_endLine++;
         m_endColumn = 0;
       }
     }
 
     m_script.Reset(m_isolate, script);
   }
 
   bool isLiveEdit() const override { return m_isLiveEdit; }
 
-  const String16& executionContextAuxData() const override {
-    return m_executionContextAuxData;
-  }
-
   const String16& sourceMappingURL() const override {
     return m_sourceMappingURL;
   }
 
   String16 source(v8::Isolate* isolate) const override {
     if (!m_sourceObj.IsEmpty())
       return toProtocolString(m_sourceObj.Get(isolate));
     return V8DebuggerScript::source(isolate);
   }
 
@@ skipping 18 matching lines @@
  private:
   String16 GetNameOrSourceUrl(v8::Local<v8::debug::Script> script) {
     v8::Local<v8::String> name;
     if (script->Name().ToLocal(&name) || script->SourceURL().ToLocal(&name))
       return toProtocolString(name);
     return String16();
   }
 
   String16 m_sourceMappingURL;
   v8::Global<v8::String> m_sourceObj;
-  String16 m_executionContextAuxData;
   bool m_isLiveEdit = false;
   v8::Global<v8::debug::Script> m_script;
 };
 
 class WasmVirtualScript : public V8DebuggerScript {
   friend class V8DebuggerScript;
 
  public:
   WasmVirtualScript(v8::Isolate* isolate,
                     v8::Local<v8::debug::WasmScript> script, String16 id,
                     String16 url, String16 source)
       : V8DebuggerScript(isolate, std::move(id), std::move(url)),
         m_script(isolate, script) {
     int num_lines = 0;
     int last_newline = -1;
     size_t next_newline = source.find('\n', last_newline + 1);
     while (next_newline != String16::kNotFound) {
       last_newline = static_cast<int>(next_newline);
       next_newline = source.find('\n', last_newline + 1);
       ++num_lines;
     }
     m_endLine = num_lines;
     m_endColumn = static_cast<int>(source.length()) - last_newline - 1;
     m_source = std::move(source);
   }
 
   const String16& sourceMappingURL() const override { return emptyString(); }
-  const String16& executionContextAuxData() const override {
-    return emptyString();
-  }
   bool isLiveEdit() const override { return false; }
   void setSourceMappingURL(const String16&) override {}
 
   bool getPossibleBreakpoints(
       const v8::debug::Location& start, const v8::debug::Location& end,
       std::vector<v8::debug::Location>* locations) override {
     // TODO(clemensh): Returning false produces the protocol error "Internal
     // error". Implement and fix expected output of
     // wasm-get-breakable-locations.js.
     return false;
@@ skipping 39 matching lines @@
   if (m_hash.isEmpty()) m_hash = calculateHash(source(isolate));
   DCHECK(!m_hash.isEmpty());
   return m_hash;
 }
 
 void V8DebuggerScript::setSourceURL(const String16& sourceURL) {
   m_sourceURL = sourceURL;
 }
 
 }  // namespace v8_inspector