Add generic functions for getting typed variation parameter values

Add generic functions for getting typed variation parameter values

This CL introduces generic functions for parsing variation parameters
into int, double, and bool (internally, variation parameters are
represented by a string).

The CL replaces some functions emulating this functionality in
ntp_snippets by the new ones in variations. More clean-up in
ntp_snippets is needed, left for further CLs.

BUG=671979
Committed: https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797
Cr-Commit-Position: refs/heads/master@{#437491}

[jkrcal, 2016-12-07 10:02:04]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 10:02:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkrcal, 2016-12-07 10:03:01]

jkrcal@chromium.org changed reviewers:
+ asvitkine@chromium.org, treib@chromium.org

[jkrcal, 2016-12-07 10:03:02]

Alexei, could you PTAL at components/variations/*?
Marc, could you PTAL at */ntp_snippets/*?

[Marc Treib, 2016-12-07 10:06:20]

ntp_snippets LGTM, thanks!

[commit-bot: I haz the power, 2016-12-07 11:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 11:39:02]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2016-12-08 13:51:47]

Thanks, Marc!

Alexei, friendly ping!

[Alexei Svitkine (slow), 2016-12-08 21:08:33]

lgtm

https://codereview.chromium.org/2558743003/diff/1/components/variations/varia...
File components/variations/variations_associated_data.cc (right):

https://codereview.chromium.org/2558743003/diff/1/components/variations/varia...
components/variations/variations_associated_data.cc:202: LOG(WARNING) << "Failed
to parse variation param " << param_name
Please turn these into DLOG()'s.

LOG() lines are not advised because they produce useless console spam for end
users and bloat the binary.

https://codereview.chromium.org/2558743003/diff/1/components/variations/varia...
components/variations/variations_associated_data.cc:237: if (value_as_string ==
"true") {
Nit: No {}'s here and below.

[jkrcal, 2016-12-09 06:59:32]

Thanks, Alexei!

https://codereview.chromium.org/2558743003/diff/1/components/variations/varia...
File components/variations/variations_associated_data.cc (right):

https://codereview.chromium.org/2558743003/diff/1/components/variations/varia...
components/variations/variations_associated_data.cc:202: LOG(WARNING) << "Failed
to parse variation param " << param_name
On 2016/12/08 21:08:33, Alexei Svitkine (slow) wrote:
> Please turn these into DLOG()'s.
> 
> LOG() lines are not advised because they produce useless console spam for end
> users and bloat the binary.

Done.

https://codereview.chromium.org/2558743003/diff/1/components/variations/varia...
components/variations/variations_associated_data.cc:237: if (value_as_string ==
"true") {
On 2016/12/08 21:08:32, Alexei Svitkine (slow) wrote:
> Nit: No {}'s here and below.

Done.

[jkrcal, 2016-12-09 06:59:45]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2016-12-09 06:59:46]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2558743003/#ps20001
(title: "Alexei's comments")

[commit-bot: I haz the power, 2016-12-09 06:59:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 07:44:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481266785825490,
"parent_rev": "1ecade0db61e3122b667c92b90974ceb60ceb37a", "commit_rev":
"c31329f71023c6133e2a9ab397f4427a07e45e1e"}

[commit-bot: I haz the power, 2016-12-09 07:44:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-09 07:47:04]

Description was changed from

==========
Add generic functions for getting typed variation parameter values

This CL introduces generic functions for parsing variation parameters
into int, double, and bool (internally, variation parameters are
represented by a string).

The CL replaces some functions emulating this functionality in
ntp_snippets by the new ones in variations. More clean-up in
ntp_snippets is needed, left for further CLs.

BUG=671979
==========

to

==========
Add generic functions for getting typed variation parameter values

This CL introduces generic functions for parsing variation parameters
into int, double, and bool (internally, variation parameters are
represented by a string).

The CL replaces some functions emulating this functionality in
ntp_snippets by the new ones in variations. More clean-up in
ntp_snippets is needed, left for further CLs.

BUG=671979

Committed: https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797
Cr-Commit-Position: refs/heads/master@{#437491}
==========

[commit-bot: I haz the power, 2016-12-09 07:47:05]

Patchset 2 (id:??) landed as
https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797
Cr-Commit-Position: refs/heads/master@{#437491}