Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: components/ntp_snippets/features.h

Issue 2558743003: Add generic functions for getting typed variation parameter values (Closed)
Patch Set: Alexei's comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/features.h
diff --git a/components/ntp_snippets/features.h b/components/ntp_snippets/features.h
index 25a3a295aa30639ca9a92d0a4b498af89a7fee7b..3e90b3fead83b0177fac0e46029233b49ea59b9a 100644
--- a/components/ntp_snippets/features.h
+++ b/components/ntp_snippets/features.h
@@ -38,17 +38,6 @@ extern const base::Feature kIncreasedVisibility;
// Feature to enable the Fetch More action
extern const base::Feature kFetchMoreFeature;
-// Returns a feature param as an int instead of a string.
-int GetParamAsInt(const base::Feature& feature,
- const std::string& param_name,
- int default_value);
-
-// Returns a feature param as a bool instead of a string.
-// TODO(jkrcal): Use this function in other code in the ntp_snippets component.
-bool GetParamAsBool(const base::Feature& feature,
- const std::string& param_name,
- bool default_value);
-
} // namespace ntp_snippets
#endif // COMPONENTS_NTP_SNIPPETS_FEATURES_H_
« no previous file with comments | « components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc ('k') | components/ntp_snippets/features.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698