Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

Issue 2558743003: Add generic functions for getting typed variation parameter values (Closed)
Patch Set: Alexei's comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
diff --git a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
index 5178292330f217f6dfe182ff627df378e52f6724..c82de24924310958969547df85e6175a02e42a23 100644
--- a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
+++ b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
@@ -22,6 +22,7 @@
#include "components/prefs/pref_service.h"
#include "components/sessions/core/session_types.h"
#include "components/sync_sessions/synced_session.h"
+#include "components/variations/variations_associated_data.h"
#include "grit/components_strings.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/image/image.h"
@@ -49,18 +50,19 @@ const char* kMaxForeignTabAgeInMinutesParamName =
"max_foreign_tabs_age_in_minutes";
int GetMaxForeignTabsTotal() {
- return GetParamAsInt(ntp_snippets::kForeignSessionsSuggestionsFeature,
- kMaxForeignTabsTotalParamName, kMaxForeignTabsTotal);
+ return variations::GetVariationParamByFeatureAsInt(
+ ntp_snippets::kForeignSessionsSuggestionsFeature,
+ kMaxForeignTabsTotalParamName, kMaxForeignTabsTotal);
}
int GetMaxForeignTabsPerDevice() {
- return GetParamAsInt(ntp_snippets::kForeignSessionsSuggestionsFeature,
- kMaxForeignTabsPerDeviceParamName,
- kMaxForeignTabsPerDevice);
+ return variations::GetVariationParamByFeatureAsInt(
+ ntp_snippets::kForeignSessionsSuggestionsFeature,
+ kMaxForeignTabsPerDeviceParamName, kMaxForeignTabsPerDevice);
}
TimeDelta GetMaxForeignTabAge() {
- return TimeDelta::FromMinutes(GetParamAsInt(
+ return TimeDelta::FromMinutes(variations::GetVariationParamByFeatureAsInt(
ntp_snippets::kForeignSessionsSuggestionsFeature,
kMaxForeignTabAgeInMinutesParamName, kMaxForeignTabAgeInMinutes));
}
« no previous file with comments | « components/ntp_snippets/remote/remote_suggestions_scheduler.h ('k') | components/ntp_snippets/user_classifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698