Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Issue 2558743003: Add generic functions for getting typed variation parameter values (Closed)
Patch Set: Alexei's comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ntp_snippets/download_suggestions_provider.cc ('k') | components/ntp_snippets/features.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
index b27ba5d9a18469bc504e66682f280702b28032a7..c8f934637aba2f83b126997a41f39bfca3cfa810 100644
--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
@@ -49,20 +49,22 @@ const char kDeprecatedBookmarksFirstM54StartPref[] =
// Note that bookmarks can be shown that do not meet this threshold.
base::Time GetThresholdTime() {
return base::Time::Now() -
- base::TimeDelta::FromDays(GetParamAsInt(
+ base::TimeDelta::FromDays(variations::GetVariationParamByFeatureAsInt(
ntp_snippets::kBookmarkSuggestionsFeature,
kMaxBookmarkAgeInDaysParamName, kMaxBookmarkAgeInDays));
}
// The maximum number of suggestions ever provided.
int GetMaxCount() {
- return GetParamAsInt(ntp_snippets::kBookmarkSuggestionsFeature,
- kMaxBookmarksParamName, kMaxBookmarks);
+ return variations::GetVariationParamByFeatureAsInt(
+ ntp_snippets::kBookmarkSuggestionsFeature, kMaxBookmarksParamName,
+ kMaxBookmarks);
}
bool AreDesktopVisitsConsidered() {
- return GetParamAsBool(ntp_snippets::kBookmarkSuggestionsFeature,
- kConsiderDesktopVisitsParamName, false);
+ return variations::GetVariationParamByFeatureAsBool(
+ ntp_snippets::kBookmarkSuggestionsFeature,
+ kConsiderDesktopVisitsParamName, false);
}
} // namespace
« no previous file with comments | « chrome/browser/ntp_snippets/download_suggestions_provider.cc ('k') | components/ntp_snippets/features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698