Sort fields in ComputedStyleBase in decreasing order of size

Sort fields in ComputedStyleBase in decreasing order of size

Sort fields in ComputedStyleBase in decreasing order of size. This is
a micro optimization that improves field alignment and minimizes wasted
memory space.

From Intel on 'Coding for Performance':
https://software.intel.com/en-us/articles/coding-for-performance-data-alignment-and-structures
"One can try to minimize this memory wastage by ordering the structure
elements such that the widest (largest) element comes first, followed by
the second widest, and so on."

Another good explanation article:
https://msdn.microsoft.com/en-us/library/ewwyfdbe.aspx

BUG=628043
Committed: https://crrev.com/a642f81bd7da2c6b02bd288c443c8e42416baa58
Cr-Commit-Position: refs/heads/master@{#437813}

[sashab, 2016-12-07 05:28:20]

Description was changed from

==========
done

BUG=628043
==========

to

==========
Sort fields in ComputedStyleBase in decreasing order of size

Sort fields in ComputedStyleBase in decreasing order of size. This is
a micro optimization that improves field alignment and minimizes wasted
memory space.

From Intel on 'Coding for Performance':
https://software.intel.com/en-us/articles/coding-for-performance-data-alignme...
"One can try to minimize this memory wastage by ordering the structure
elements such that the widest (largest) element comes first, followed by
the second widest, and so on."

BUG=628043
==========

[sashab, 2016-12-07 05:28:26]

sashab@chromium.org changed reviewers:
+ napper@chromium.org

[sashab, 2016-12-07 05:33:59]

Description was changed from

==========
Sort fields in ComputedStyleBase in decreasing order of size

Sort fields in ComputedStyleBase in decreasing order of size. This is
a micro optimization that improves field alignment and minimizes wasted
memory space.

From Intel on 'Coding for Performance':
https://software.intel.com/en-us/articles/coding-for-performance-data-alignme...
"One can try to minimize this memory wastage by ordering the structure
elements such that the widest (largest) element comes first, followed by
the second widest, and so on."

BUG=628043
==========

to

==========
Sort fields in ComputedStyleBase in decreasing order of size

Sort fields in ComputedStyleBase in decreasing order of size. This is
a micro optimization that improves field alignment and minimizes wasted
memory space.

From Intel on 'Coding for Performance':
https://software.intel.com/en-us/articles/coding-for-performance-data-alignme...
"One can try to minimize this memory wastage by ordering the structure
elements such that the widest (largest) element comes first, followed by
the second widest, and so on."

Another good explanation article:
https://msdn.microsoft.com/en-us/library/ewwyfdbe.aspx

BUG=628043
==========

[napper, 2016-12-07 05:54:34]

lgtm

[sashab, 2016-12-07 06:21:48]

sashab@chromium.org changed reviewers:
+ loyso@chromium.org

[sashab, 2016-12-07 06:21:48]

alexey for follow-up review :)

[loyso (OOO), 2016-12-07 06:45:06]

On 2016/12/07 at 06:21:48, sashab wrote:
> alexey for follow-up review :)

LGTM! Glad to see that the art of structure packing is back :)

[sashab, 2016-12-12 01:54:58]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-12-12 01:55:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 03:17:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481507698286870, "parent_rev":
"d5e6d402f88c8dcbbdfffbe191343ccc12dbf899", "commit_rev":
"15fe027e6efd9f133b3caff34df248031dbedd5f"}

[commit-bot: I haz the power, 2016-12-12 03:18:42]

Description was changed from

==========
Sort fields in ComputedStyleBase in decreasing order of size

Sort fields in ComputedStyleBase in decreasing order of size. This is
a micro optimization that improves field alignment and minimizes wasted
memory space.

From Intel on 'Coding for Performance':
https://software.intel.com/en-us/articles/coding-for-performance-data-alignme...
"One can try to minimize this memory wastage by ordering the structure
elements such that the widest (largest) element comes first, followed by
the second widest, and so on."

Another good explanation article:
https://msdn.microsoft.com/en-us/library/ewwyfdbe.aspx

BUG=628043
==========

to

==========
Sort fields in ComputedStyleBase in decreasing order of size

Sort fields in ComputedStyleBase in decreasing order of size. This is
a micro optimization that improves field alignment and minimizes wasted
memory space.

From Intel on 'Coding for Performance':
https://software.intel.com/en-us/articles/coding-for-performance-data-alignme...
"One can try to minimize this memory wastage by ordering the structure
elements such that the widest (largest) element comes first, followed by
the second widest, and so on."

Another good explanation article:
https://msdn.microsoft.com/en-us/library/ewwyfdbe.aspx

BUG=628043

Review-Url: https://codereview.chromium.org/2558733002
==========

[commit-bot: I haz the power, 2016-12-12 03:18:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 15:10:21]

Description was changed from

==========
Sort fields in ComputedStyleBase in decreasing order of size

Sort fields in ComputedStyleBase in decreasing order of size. This is
a micro optimization that improves field alignment and minimizes wasted
memory space.

From Intel on 'Coding for Performance':
https://software.intel.com/en-us/articles/coding-for-performance-data-alignme...
"One can try to minimize this memory wastage by ordering the structure
elements such that the widest (largest) element comes first, followed by
the second widest, and so on."

Another good explanation article:
https://msdn.microsoft.com/en-us/library/ewwyfdbe.aspx

BUG=628043

Review-Url: https://codereview.chromium.org/2558733002
==========

to

==========
Sort fields in ComputedStyleBase in decreasing order of size

Sort fields in ComputedStyleBase in decreasing order of size. This is
a micro optimization that improves field alignment and minimizes wasted
memory space.

From Intel on 'Coding for Performance':
https://software.intel.com/en-us/articles/coding-for-performance-data-alignme...
"One can try to minimize this memory wastage by ordering the structure
elements such that the widest (largest) element comes first, followed by
the second widest, and so on."

Another good explanation article:
https://msdn.microsoft.com/en-us/library/ewwyfdbe.aspx

BUG=628043

Committed: https://crrev.com/a642f81bd7da2c6b02bd288c443c8e42416baa58
Cr-Commit-Position: refs/heads/master@{#437813}
==========

[commit-bot: I haz the power, 2016-12-12 15:10:22]

Patchset 1 (id:??) landed as
https://crrev.com/a642f81bd7da2c6b02bd288c443c8e42416baa58
Cr-Commit-Position: refs/heads/master@{#437813}