Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2554243002: Removed property object from make_computed_style_base.py templates (Closed)

Created:
4 years ago by sashab
Modified:
4 years ago
Reviewers:
napper, nainar
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed property object from make_computed_style_base.py templates Removed references to the property object from templates used in make_computed_style_base.py. This is important pre-work for adding fields that don't have a property object associated with them, but even if those aren't added, reducing the amount of information sent to the templates makes the code easier to follow and understand. BUG=628043 Committed: https://crrev.com/c2ff63fad7483656ea28d0d9e35267add5fd29f6 Cr-Commit-Position: refs/heads/master@{#437456}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 4 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
sashab
4 years ago (2016-12-07 03:58:39 UTC) #2
napper
lgtm
4 years ago (2016-12-07 05:58:21 UTC) #5
sashab
nainar@ for follow up review
4 years ago (2016-12-07 06:21:16 UTC) #9
nainar
lgtm
4 years ago (2016-12-07 06:30:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554243002/1
4 years ago (2016-12-08 23:24:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554243002/20001
4 years ago (2016-12-08 23:33:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/177523) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-08 23:40:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554243002/20001
4 years ago (2016-12-09 00:24:38 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 03:48:16 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-09 03:52:31 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2ff63fad7483656ea28d0d9e35267add5fd29f6
Cr-Commit-Position: refs/heads/master@{#437456}

Powered by Google App Engine
This is Rietveld 408576698