Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2563853002: Renamed 'type' to 'storage_type' in make_computed_style_base.py (Closed)

Created:
4 years ago by sashab
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed 'type' to 'storage_type' in make_computed_style_base.py Renamed the Field attribute 'type' to 'storage_type' in make_computed_style_base.py and the ComputedStyleBase template files. This is pre-work for when Fields can have both an internal storage and external type (new attribute 'external_type'), and these types need to be distinguished without being confusing. BUG=628043 Committed: https://crrev.com/a0c2bf8d4b53aaace5bb38f4b7cb7078c7c2bf2d Cr-Commit-Position: refs/heads/master@{#438022}

Patch Set 1 #

Patch Set 2 : Rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 29 (17 generated)
sashab
Oops thought I sent this out earlier. PTAL
4 years ago (2016-12-12 03:32:14 UTC) #6
napper
lgtm
4 years ago (2016-12-12 03:54:23 UTC) #7
sashab
alancutter@ ptal :)
4 years ago (2016-12-12 04:00:00 UTC) #9
alancutter (OOO until 2018)
lgtm
4 years ago (2016-12-12 22:20:50 UTC) #10
alancutter (OOO until 2018)
I wonder if storage_type would be a more accurate name.
4 years ago (2016-12-12 22:22:35 UTC) #11
sashab
Ahhhhh it's so true! Ptal. :)
4 years ago (2016-12-12 23:39:25 UTC) #13
alancutter (OOO until 2018)
lgtm
4 years ago (2016-12-12 23:54:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563853002/20001
4 years ago (2016-12-12 23:59:39 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/331698)
4 years ago (2016-12-13 01:38:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563853002/20001
4 years ago (2016-12-13 01:50:14 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 03:24:04 UTC) #27
commit-bot: I haz the power
4 years ago (2016-12-13 03:26:41 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0c2bf8d4b53aaace5bb38f4b7cb7078c7c2bf2d
Cr-Commit-Position: refs/heads/master@{#438022}

Powered by Google App Engine
This is Rietveld 408576698