|
|
DescriptionRenamed 'type' to 'storage_type' in make_computed_style_base.py
Renamed the Field attribute 'type' to 'storage_type' in
make_computed_style_base.py and the ComputedStyleBase template files.
This is pre-work for when Fields can have both an internal storage and
external type (new attribute 'external_type'), and these types need to
be distinguished without being confusing.
BUG=628043
Committed: https://crrev.com/a0c2bf8d4b53aaace5bb38f4b7cb7078c7c2bf2d
Cr-Commit-Position: refs/heads/master@{#438022}
Patch Set 1 #Patch Set 2 : Rename #
Messages
Total messages: 29 (17 generated)
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sashab@chromium.org changed reviewers: + napper@chromium.org
Oops thought I sent this out earlier. PTAL
lgtm
sashab@chromium.org changed reviewers: + alancutter@chromium.org
alancutter@ ptal :)
lgtm
I wonder if storage_type would be a more accurate name.
Description was changed from ========== Renamed 'type' to 'internal_type' in make_computed_style_base.py Renamed the Field attribute 'type' to 'internal_type' in make_computed_style_base.py and the ComputedStyleBase template files. This is pre-work for when Fields can have both an internal and external type (new attribute 'external_type'), and these types need to be distinguished without being confusing. BUG=628043 ========== to ========== Renamed 'type' to 'storage_type' in make_computed_style_base.py Renamed the Field attribute 'type' to 'storage_type' in make_computed_style_base.py and the ComputedStyleBase template files. This is pre-work for when Fields can have both an internal storage and external type (new attribute 'external_type'), and these types need to be distinguished without being confusing. BUG=628043 ==========
Ahhhhh it's so true! Ptal. :)
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by sashab@chromium.org
The CQ bit was checked by sashab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from napper@chromium.org Link to the patchset: https://codereview.chromium.org/2563853002/#ps20001 (title: "Rename")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481593782007700, "parent_rev": "426b200a4b692b0899e792f93b9055fed78a481d", "commit_rev": "485ec50869f9e0a1c982c48aa2be97103d85cda7"}
Message was sent while issue was closed.
Description was changed from ========== Renamed 'type' to 'storage_type' in make_computed_style_base.py Renamed the Field attribute 'type' to 'storage_type' in make_computed_style_base.py and the ComputedStyleBase template files. This is pre-work for when Fields can have both an internal storage and external type (new attribute 'external_type'), and these types need to be distinguished without being confusing. BUG=628043 ========== to ========== Renamed 'type' to 'storage_type' in make_computed_style_base.py Renamed the Field attribute 'type' to 'storage_type' in make_computed_style_base.py and the ComputedStyleBase template files. This is pre-work for when Fields can have both an internal storage and external type (new attribute 'external_type'), and these types need to be distinguished without being confusing. BUG=628043 Review-Url: https://codereview.chromium.org/2563853002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Renamed 'type' to 'storage_type' in make_computed_style_base.py Renamed the Field attribute 'type' to 'storage_type' in make_computed_style_base.py and the ComputedStyleBase template files. This is pre-work for when Fields can have both an internal storage and external type (new attribute 'external_type'), and these types need to be distinguished without being confusing. BUG=628043 Review-Url: https://codereview.chromium.org/2563853002 ========== to ========== Renamed 'type' to 'storage_type' in make_computed_style_base.py Renamed the Field attribute 'type' to 'storage_type' in make_computed_style_base.py and the ComputedStyleBase template files. This is pre-work for when Fields can have both an internal storage and external type (new attribute 'external_type'), and these types need to be distinguished without being confusing. BUG=628043 Committed: https://crrev.com/a0c2bf8d4b53aaace5bb38f4b7cb7078c7c2bf2d Cr-Commit-Position: refs/heads/master@{#438022} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a0c2bf8d4b53aaace5bb38f4b7cb7078c7c2bf2d Cr-Commit-Position: refs/heads/master@{#438022} |