Make old version bots show up yellow on botlist

Make old version bots show up yellow on botlist

Also make "bot" i.e. "Bot Assigned" column show up by default in task
list

BUG=672517
Review-Url: https://codereview.chromium.org/2558633009
Committed: https://github.com/luci/luci-py/commit/2ebd542bd0771108214f27634ac8c17a26a43808

[kjlubick, 2016-12-09 20:42:05]

kjlubick@google.com changed reviewers:
+ maruel@chromium.org, stephana@chromium.org

[kjlubick, 2016-12-09 20:42:06]

Bots with old versions are highlighted yellow, just like old events on bot-page
https://screenshot.googleplex.com/obuz8RbWsGt

[M-A Ruel, 2016-12-09 20:57:13]

https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/botlist/bot-list.html:615: if (bot.version !==
serverVersion) {
I'd prefer these to be additive.

https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/tasklist/task-filters.html (right):

https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/tasklist/task-filters.html:58:
default_values='["name","state","created_ts","user","bot"]'
"bot" is a confusing name for "bot_version" :/

[kjlubick, 2016-12-12 13:25:53]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com
- stephana@chromium.org

[kjlubick, 2016-12-12 13:25:54]

https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/tasklist/task-filters.html (right):

https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/tasklist/task-filters.html:58:
default_values='["name","state","created_ts","user","bot"]'
On 2016/12/09 at 20:57:13, M-A Ruel wrote:
> "bot" is a confusing name for "bot_version" :/

"bot" means "Bot Assigned".  This change is just adding visibility into what bot
ran what tasks by default.

[kjlubick, 2016-12-12 13:26:11]

https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/botlist/bot-list.html:615: if (bot.version !==
serverVersion) {
On 2016/12/09 at 20:57:13, M-A Ruel wrote:
> I'd prefer these to be additive.

Done.

[jcgregorio, 2016-12-12 14:06:52]

lgtm

[M-A Ruel, 2016-12-12 18:40:08]

lgtm

[kjlubick, 2016-12-12 18:42:28]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-12-12 18:42:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 18:46:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481568148445090,
"parent_rev": "011b3b59ef976e4f9c9272751be004ee8d5a7cce", "commit_rev":
"2ebd542bd0771108214f27634ac8c17a26a43808"}

[commit-bot: I haz the power, 2016-12-12 18:46:12]

Description was changed from

==========
Make old version bots show up yellow on botlist

Also make "bot" i.e. "Bot Assigned" column show up by default in task
list

BUG=672517
==========

to

==========
Make old version bots show up yellow on botlist

Also make "bot" i.e. "Bot Assigned" column show up by default in task
list

BUG=672517

Review-Url: https://codereview.chromium.org/2558633009
Committed:
https://github.com/luci/luci-py/commit/2ebd542bd0771108214f27634ac8c17a26a43808
==========

[commit-bot: I haz the power, 2016-12-12 18:46:13]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/2ebd542bd0771108214f27634ac8c17a26a43808