Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2558633009: Make old version bots show up yellow on botlist (Closed)

Created:
4 years ago by kjlubick
Modified:
4 years ago
Reviewers:
jcgregorio, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Make old version bots show up yellow on botlist Also make "bot" i.e. "Bot Assigned" column show up by default in task list BUG=672517 Review-Url: https://codereview.chromium.org/2558633009 Committed: https://github.com/luci/luci-py/commit/2ebd542bd0771108214f27634ac8c17a26a43808

Patch Set 1 #

Total comments: 4

Patch Set 2 : Make classes additive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 3 chunks +10 lines, -6 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list.html View 1 3 chunks +12 lines, -5 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list-demo.html View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-filters.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
kjlubick
Bots with old versions are highlighted yellow, just like old events on bot-page https://screenshot.googleplex.com/obuz8RbWsGt
4 years ago (2016-12-09 20:42:06 UTC) #2
M-A Ruel
https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/imp/botlist/bot-list.html File appengine/swarming/ui/res/imp/botlist/bot-list.html (right): https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/imp/botlist/bot-list.html#newcode615 appengine/swarming/ui/res/imp/botlist/bot-list.html:615: if (bot.version !== serverVersion) { I'd prefer these to ...
4 years ago (2016-12-09 20:57:13 UTC) #3
kjlubick
https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/imp/tasklist/task-filters.html File appengine/swarming/ui/res/imp/tasklist/task-filters.html (right): https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/imp/tasklist/task-filters.html#newcode58 appengine/swarming/ui/res/imp/tasklist/task-filters.html:58: default_values='["name","state","created_ts","user","bot"]' On 2016/12/09 at 20:57:13, M-A Ruel wrote: > ...
4 years ago (2016-12-12 13:25:54 UTC) #5
kjlubick
https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/imp/botlist/bot-list.html File appengine/swarming/ui/res/imp/botlist/bot-list.html (right): https://codereview.chromium.org/2558633009/diff/1/appengine/swarming/ui/res/imp/botlist/bot-list.html#newcode615 appengine/swarming/ui/res/imp/botlist/bot-list.html:615: if (bot.version !== serverVersion) { On 2016/12/09 at 20:57:13, ...
4 years ago (2016-12-12 13:26:11 UTC) #6
jcgregorio
lgtm
4 years ago (2016-12-12 14:06:52 UTC) #7
M-A Ruel
lgtm
4 years ago (2016-12-12 18:40:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558633009/20001
4 years ago (2016-12-12 18:42:34 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-12 18:46:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/2ebd542bd0771108214f27634ac8c17a26a43808

Powered by Google App Engine
This is Rietveld 408576698