Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: appengine/swarming/ui/res/imp/botlist/bot-list.html

Issue 2558633009: Make old version bots show up yellow on botlist (Closed)
Patch Set: Make classes additive Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/ui/build/elements.html ('k') | appengine/swarming/ui/res/imp/botlist/bot-list-demo.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/ui/res/imp/botlist/bot-list.html
diff --git a/appengine/swarming/ui/res/imp/botlist/bot-list.html b/appengine/swarming/ui/res/imp/botlist/bot-list.html
index 2d3c7226a81c653fc2980579a167a7a97fba44bf..6a30369fa24c25b46c960b1f6f0ea543721f241b 100644
--- a/appengine/swarming/ui/res/imp/botlist/bot-list.html
+++ b/appengine/swarming/ui/res/imp/botlist/bot-list.html
@@ -45,6 +45,9 @@
margin-bottom: 8px;
margin-right: 10px;
}
+ .old_version {
+ background-color: #ffffdd;
+ }
.quarantined, .bad-device {
background-color: #ffdddd;
}
@@ -183,7 +186,7 @@
as="bot"
initial-count=50>
- <tr class$="[[_botClass(bot)]]">
+ <tr class$="[[_botClass(bot,_server_details.bot_version)]]">
<td>
<a
class="center"
@@ -602,14 +605,18 @@
return swarming.alias.android(this._deviceType(device));
},
- _botClass: function(bot) {
+ _botClass: function(bot, serverVersion) {
+ var classes = "";
if (bot.is_dead) {
- return "dead";
+ classes += "dead ";
}
if (bot.quarantined) {
- return "quarantined";
+ classes += "quarantined ";
}
- return "";
+ if (bot.version !== serverVersion) {
+ classes += "old_version";
+ }
+ return classes;
},
_ccLink: function(bot){
« no previous file with comments | « appengine/swarming/ui/build/elements.html ('k') | appengine/swarming/ui/res/imp/botlist/bot-list-demo.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698