Make old version bots show up yellow on botlist

appengine/swarming/ui/res/imp/botlist/bot-list.html

 <!--
   Copyright 2016 The LUCI Authors. All rights reserved.
   Use of this source code is governed under the Apache License, Version 2.0
   that can be found in the LICENSE file.
 
   This in an HTML Import-able file that contains the definition
   of the following elements:
 
     <bot-list>
 
@@ skipping 40 matching lines @@
       .dead {
         background-color: #cccccc;
       }
       .alt {
         background-color: #f8f8f8;
       }
       .bot-list th > span {
         /* Leave space for sort-toggle*/
         padding-right: 30px;
       }
+      .old_version {
+        background-color: #ffffdd;
+      }
     </style>
 
     <url-param name="s"
       value="{{_sortstr}}"
       default_value="id:asc">
     </url-param>
 
     <swarming-app
       client_id="[[client_id]]"
       auth_headers="{{_auth_headers}}"
@@ skipping 105 matching lines @@
             </tr>
           </thead>
           <tbody>
             <template
                 id="bot_table"
                 is="dom-repeat"
                 items="[[_filteredSortedItems]]"
                 as="bot"
                 initial-count=50>
 
-              <tr class$="[[_botClass(bot)]]">
+              <tr class$="[[_botClass(bot,_server_details.bot_version)]]">
                 <td>
                   <a
                       class="center"
                       href$="[[_botLink(bot.bot_id)]]"
                       target="_blank"
                       rel="noopener">
                       [[bot.bot_id]]
                   </a>
                 </td>
                 <td hidden$="[[_hide('cloud_console_link', _columns.*)]]">
@@ skipping 398 matching lines @@
         "_checkDeviceColumns(_columns.*)"
       ],
 
       _androidAliasDevice: function(device) {
         if (device.notReady) {
           return UNAUTHENTICATED.toUpperCase();
         }
         return swarming.alias.android(this._deviceType(device));
       },
 
-      _botClass: function(bot) {
+      _botClass: function(bot, serverVersion) {
         if (bot.is_dead) {
           return "dead";
         }
         if (bot.quarantined) {
           return "quarantined";
         }
+        if (bot.version !== serverVersion) {

[M-A Ruel, 2016/12/09 20:57:13]

I'd prefer these to be additive.

[kjlubick, 2016/12/12 13:26:11]

Done.

+          return "old_version";
+        }
         return "";
       },
 
       _ccLink: function(bot){
         var z = this._attribute(bot, "zone")[0];
         if (z === "unknown") {
           return undefined;
         }
         return this._cloudConsoleLink(z, bot.bot_id);
       },
@@ skipping 53 matching lines @@
           return;
         }
         var url = "/api/swarming/v1/bots/list?" + sk.query.fromParamSet(this._query_params);
         this.$.page_bots.load(url,this._auth_headers);
       }
 
     });
   })();
   </script>
 </dom-module>