Cleanup AudioDeviceThread to avoid accidental misuse.

Cleanup AudioDeviceThread to avoid accidental misuse.

The code as written returned the current task runner whenever
AudioDeviceThread::GetTaskRunner() was called, when actually
what we want is for it to always be bound to the constructed
thread.

This isn't an issue given that we didn't expose AudioDeviceThread
outside of BrowserMainLoop, but this prevents any future misuse
and cleans up some style issues.

Note: This also renames AudioDeviceThread to AudioManagerThread
since we already have an AudioDeviceThread in the renderer.

BUG=656923
TEST=none

Committed: https://crrev.com/d8cd11c786e0173afcc7031d85aa3cec75376b6c
Cr-Commit-Position: refs/heads/master@{#438301}

[DaleCurtis, 2016-12-13 00:29:34]

dalecurtis@chromium.org changed reviewers:
+ avi@chromium.org, maxmorin@chromium.org

[DaleCurtis, 2016-12-13 00:29:35]

Noticed this while digging through surrounding code. Again, no issue, but the
way it's written makes it easy to mess this up if we ever exposed this class
further.

[Avi (use Gerrit), 2016-12-13 01:36:11]

lgtm

grammar nits

https://codereview.chromium.org/2558303004/diff/1/content/browser/audio_devic...
File content/browser/audio_device_thread.cc (right):

https://codereview.chromium.org/2558303004/diff/1/content/browser/audio_devic...
content/browser/audio_device_thread.cc:19: // On Mac audio task runner must
belong to the main thread.
Grammar? "On the Mac, the audio ..."

https://codereview.chromium.org/2558303004/diff/1/content/browser/audio_devic...
File content/browser/audio_device_thread.h (right):

https://codereview.chromium.org/2558303004/diff/1/content/browser/audio_devic...
content/browser/audio_device_thread.h:20: // Constructs and starts a thread. On
all platforms except for OSX, the
"OSX" isn't really a thing any more. Say "the Mac" or "macOS".

[DaleCurtis, 2016-12-13 01:55:39]

Thanks for review! I'll probably send another CL tomorrow to rename this, since
we already have another class called AudioDeviceThread, this is more like
AudioManagerThread.

https://codereview.chromium.org/2558303004/diff/1/content/browser/audio_devic...
File content/browser/audio_device_thread.h (right):

https://codereview.chromium.org/2558303004/diff/1/content/browser/audio_devic...
content/browser/audio_device_thread.h:20: // Constructs and starts a thread. On
all platforms except for OSX, the
On 2016/12/13 at 01:36:11, Avi wrote:
> "OSX" isn't really a thing any more. Say "the Mac" or "macOS".

Done.

[DaleCurtis, 2016-12-13 01:56:09]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-12-13 01:56:09]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2558303004/#ps20001
(title: "Grammar.")

[commit-bot: I haz the power, 2016-12-13 01:56:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:07:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:07:43]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Max Morin, 2016-12-13 07:44:33]

LGTM, thanks for the cleanup

[DaleCurtis, 2016-12-13 19:29:17]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-12-13 19:29:18]

Went ahead and renamed in this CL since I needed to fix up a few more tests.
Thanks for review!

[DaleCurtis, 2016-12-13 19:29:18]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
maxmorin@chromium.org
Link to the patchset: https://codereview.chromium.org/2558303004/#ps40001
(title: "Rename to AudioManagerThread. Fix tests.")

[DaleCurtis, 2016-12-13 19:29:43]

Description was changed from

==========
Cleanup AudioDeviceThread to avoid accidental misuse.

The code as written returned the current task runner whenever
AudioDeviceThread::GetTaskRunner() was called, when actually
what we want is for it to always be bound to the constructed
thread.

This isn't an issue given that we didn't expose AudioDeviceThread
outside of BrowserMainLoop, but this prevents any future misuse
and cleans up some style issues.

BUG=656923
TEST=none
==========

to

==========
Cleanup AudioDeviceThread to avoid accidental misuse.

The code as written returned the current task runner whenever
AudioDeviceThread::GetTaskRunner() was called, when actually
what we want is for it to always be bound to the constructed
thread.

This isn't an issue given that we didn't expose AudioDeviceThread
outside of BrowserMainLoop, but this prevents any future misuse
and cleans up some style issues.

Note: This also renames AudioDeviceThread to AudioManagerThread
since we already have an AudioDeviceThread in the renderer.

BUG=656923
TEST=none
==========

[commit-bot: I haz the power, 2016-12-13 19:29:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 21:56:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481657357919680,
"parent_rev": "99cb11441888ea3365c7361c3b5722dd66299d65", "commit_rev":
"b368e6940423e435a7720d82a82c220ad1d55b42"}

[commit-bot: I haz the power, 2016-12-13 21:57:13]

Description was changed from

==========
Cleanup AudioDeviceThread to avoid accidental misuse.

The code as written returned the current task runner whenever
AudioDeviceThread::GetTaskRunner() was called, when actually
what we want is for it to always be bound to the constructed
thread.

This isn't an issue given that we didn't expose AudioDeviceThread
outside of BrowserMainLoop, but this prevents any future misuse
and cleans up some style issues.

Note: This also renames AudioDeviceThread to AudioManagerThread
since we already have an AudioDeviceThread in the renderer.

BUG=656923
TEST=none
==========

to

==========
Cleanup AudioDeviceThread to avoid accidental misuse.

The code as written returned the current task runner whenever
AudioDeviceThread::GetTaskRunner() was called, when actually
what we want is for it to always be bound to the constructed
thread.

This isn't an issue given that we didn't expose AudioDeviceThread
outside of BrowserMainLoop, but this prevents any future misuse
and cleans up some style issues.

Note: This also renames AudioDeviceThread to AudioManagerThread
since we already have an AudioDeviceThread in the renderer.

BUG=656923
TEST=none

Review-Url: https://codereview.chromium.org/2558303004
==========

[commit-bot: I haz the power, 2016-12-13 21:57:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 22:00:51]

Description was changed from

==========
Cleanup AudioDeviceThread to avoid accidental misuse.

The code as written returned the current task runner whenever
AudioDeviceThread::GetTaskRunner() was called, when actually
what we want is for it to always be bound to the constructed
thread.

This isn't an issue given that we didn't expose AudioDeviceThread
outside of BrowserMainLoop, but this prevents any future misuse
and cleans up some style issues.

Note: This also renames AudioDeviceThread to AudioManagerThread
since we already have an AudioDeviceThread in the renderer.

BUG=656923
TEST=none

Review-Url: https://codereview.chromium.org/2558303004
==========

to

==========
Cleanup AudioDeviceThread to avoid accidental misuse.

The code as written returned the current task runner whenever
AudioDeviceThread::GetTaskRunner() was called, when actually
what we want is for it to always be bound to the constructed
thread.

This isn't an issue given that we didn't expose AudioDeviceThread
outside of BrowserMainLoop, but this prevents any future misuse
and cleans up some style issues.

Note: This also renames AudioDeviceThread to AudioManagerThread
since we already have an AudioDeviceThread in the renderer.

BUG=656923
TEST=none

Committed: https://crrev.com/d8cd11c786e0173afcc7031d85aa3cec75376b6c
Cr-Commit-Position: refs/heads/master@{#438301}
==========

[commit-bot: I haz the power, 2016-12-13 22:00:52]

Patchset 3 (id:??) landed as
https://crrev.com/d8cd11c786e0173afcc7031d85aa3cec75376b6c
Cr-Commit-Position: refs/heads/master@{#438301}