Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2557943002: Sync requestFullscreen() and exitFullscreen() algorithms with the spec (Closed)

Created:
4 years ago by foolip
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, shans, szager+layoutwatch_chromium.org, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, Srirama, kinuko+watch, rwlbuis, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, blink-reviews, Eric Willigers, blink-reviews-w3ctests_chromium.org, nessy, rjwright, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, sof, feature-media-reviews_chromium.org, feature-vr-reviews_chromium.org, dcheng, darktears, haraken, vcarbune.chromium, mlamouri+watch-blink_chromium.org, tfarina, pdr+renderingwatchlist_chromium.org, gasubic, leviw+renderwatch, blink-reviews-animation_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync requestFullscreen() and exitFullscreen() algorithms with the spec This makes webkitCurrentFullScreenElement an alias of fullscreenElement. BUG=402376, 402421 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : fix failing tests #

Patch Set 3 : consolidate into fullscreenElementChanged #

Patch Set 4 : update expectations #

Patch Set 5 : revert "fully exit fullscreen" beahvior; fix webkit_unit_tests #

Patch Set 6 : oops oopif #

Patch Set 7 : fix document-exit-fullscreen-vs-request.html #

Patch Set 8 : move tricky TODO #

Patch Set 9 : tinker #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+709 lines, -692 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/document-exit-fullscreen-twice.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/document-exit-fullscreen-vs-request.html View 1 2 3 4 5 6 2 chunks +16 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/document-fullscreen-element.html View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-move.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-move-to-iframe.html View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-move-to-iframe-prefixed.html View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-remove.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-remove-iframe.html View 1 2 chunks +6 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-remove-prefixed.html View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-twice.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-two-iframes.html View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-vs-exit.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html View 1 1 chunk +23 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context.html View 1 1 chunk +3 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-fullscreen-element-manual-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-timing-manual-expected.txt View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentFullscreen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentFullscreen.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentFullscreen.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.h View 1 2 3 4 5 6 7 8 9 6 chunks +31 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 1 2 3 4 5 6 7 8 9 8 chunks +462 lines, -404 lines 0 comments Download
M third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.cpp View 1 2 3 4 5 6 7 8 4 chunks +24 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +10 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 3 4 5 6 7 8 9 16 chunks +41 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 3 4 5 6 7 8 9 7 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 35 (32 generated)
foolip
This was continued at https://codereview.chromium.org/2573773002 where it was actually reviewed and landed.
4 years ago (2016-12-20 13:57:30 UTC) #33
foolip
This was continued at https://codereview.chromium.org/2573773002 where it was actually reviewed and landed.
4 years ago (2016-12-20 13:57:31 UTC) #34
foolip
4 years ago (2016-12-20 14:02:16 UTC) #35
Message was sent while issue was closed. 
This was finally reviewed and landed in
https://codereview.chromium.org/2573773002

Powered by Google App Engine
This is Rietveld 408576698