Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2557943002: Sync requestFullscreen() and exitFullscreen() algorithms with the spec (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 1575 matching lines...) Expand 10 before | Expand all | Expand 10 after
1586 setIsInCanvasSubtree(true); 1586 setIsInCanvasSubtree(true);
1587 1587
1588 return InsertionDone; 1588 return InsertionDone;
1589 } 1589 }
1590 1590
1591 void Element::removedFrom(ContainerNode* insertionPoint) { 1591 void Element::removedFrom(ContainerNode* insertionPoint) {
1592 bool wasInDocument = insertionPoint->isConnected(); 1592 bool wasInDocument = insertionPoint->isConnected();
1593 1593
1594 DCHECK(!hasRareData() || !elementRareData()->hasPseudoElements()); 1594 DCHECK(!hasRareData() || !elementRareData()->hasPseudoElements());
1595 1595
1596 if (Fullscreen::isCurrentFullScreenElement(*this)) { 1596 if (Fullscreen::isFullscreenElement(*this)) {
1597 setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(false); 1597 setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(false);
1598 if (insertionPoint->isElementNode()) { 1598 if (insertionPoint->isElementNode()) {
1599 toElement(insertionPoint)->setContainsFullScreenElement(false); 1599 toElement(insertionPoint)->setContainsFullScreenElement(false);
1600 toElement(insertionPoint) 1600 toElement(insertionPoint)
1601 ->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries( 1601 ->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(
1602 false); 1602 false);
1603 } 1603 }
1604 } 1604 }
1605 1605
1606 if (Fullscreen* fullscreen = Fullscreen::fromIfExists(document())) 1606 if (Fullscreen* fullscreen = Fullscreen::fromIfExists(document()))
(...skipping 2394 matching lines...) Expand 10 before | Expand all | Expand 10 after
4001 if (this == document().cssTarget()) 4001 if (this == document().cssTarget())
4002 return false; 4002 return false;
4003 if (isHTMLElement() && toHTMLElement(this)->hasDirectionAuto()) 4003 if (isHTMLElement() && toHTMLElement(this)->hasDirectionAuto())
4004 return false; 4004 return false;
4005 // TODO(kochi): This prevents any slotted elements from sharing styles. 4005 // TODO(kochi): This prevents any slotted elements from sharing styles.
4006 // Investigate cases where we share styles to optimize styling performance. 4006 // Investigate cases where we share styles to optimize styling performance.
4007 if (isChildOfV1ShadowHost()) 4007 if (isChildOfV1ShadowHost())
4008 return false; 4008 return false;
4009 if (hasAnimations()) 4009 if (hasAnimations())
4010 return false; 4010 return false;
4011 if (Fullscreen::isCurrentFullScreenElement(*this)) 4011 if (Fullscreen::isFullscreenElement(*this))
4012 return false; 4012 return false;
4013 return true; 4013 return true;
4014 } 4014 }
4015 4015
4016 void Element::logAddElementIfIsolatedWorldAndInDocument( 4016 void Element::logAddElementIfIsolatedWorldAndInDocument(
4017 const char element[], 4017 const char element[],
4018 const QualifiedName& attr1) { 4018 const QualifiedName& attr1) {
4019 if (!isConnected()) 4019 if (!isConnected())
4020 return; 4020 return;
4021 V8DOMActivityLogger* activityLogger = 4021 V8DOMActivityLogger* activityLogger =
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
4091 } 4091 }
4092 4092
4093 DEFINE_TRACE_WRAPPERS(Element) { 4093 DEFINE_TRACE_WRAPPERS(Element) {
4094 if (hasRareData()) { 4094 if (hasRareData()) {
4095 visitor->traceWrappers(elementRareData()); 4095 visitor->traceWrappers(elementRareData());
4096 } 4096 }
4097 ContainerNode::traceWrappers(visitor); 4097 ContainerNode::traceWrappers(visitor);
4098 } 4098 }
4099 4099
4100 } // namespace blink 4100 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/DocumentFullscreen.idl ('k') | third_party/WebKit/Source/core/dom/Fullscreen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698