Leak instead of deadlock if executeHardwareAction fails

Leak instead of deadlock if executeHardwareAction fails

If executeHardwareAction fails in onDetachedFromWindow, then
HardwareRenderer destructor will deadlock later when being destroyed on
UI thread. In this case, run the destructor on UI without deadlock but
leak GL resources instead.

Achieve this by running always running release gl even on UI thread, and
making the allow_gl global to be a true thread local, which can be set
to true on UI thread.

BUG=
TBR=benm

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266429

[hush (inactive), 2014-04-26 01:17:29]

lgtm

[hush (inactive), 2014-04-26 01:17:36]

The CQ bit was checked by hush@chromium.org

[commit-bot: I haz the power, 2014-04-26 02:05:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/255783007/1

[commit-bot: I haz the power, 2014-04-26 02:05:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 02:05:15]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[boliu, 2014-04-26 03:14:14]

tbr benm

[boliu, 2014-04-26 03:14:18]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-04-26 03:17:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/255783007/1

[commit-bot: I haz the power, 2014-04-28 05:45:42]

Change committed as 266429

[benm (inactive), 2014-04-28 12:02:05]

Could we have a clearer log message? Also should it be log.w ?


Maybe something like "Unable to free GL resources. Has the Window leaked?"

Sent from my Android
On 26 Apr 2014 04:17, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/boliu@chromium.org/255783007/1
>
>
> https://codereview.chromium.org/255783007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[boliu, 2014-04-28 19:56:43]

On 2014/04/28 12:02:05, benm wrote:
> Could we have a clearer log message? Also should it be log.w ?
> 
> 
> Maybe something like "Unable to free GL resources. Has the Window leaked?"
> 
> Sent from my Android
> On 26 Apr 2014 04:17, <mailto:commit-bot@chromium.org> wrote:
> 
> > CQ is trying da patch. Follow status at
> > https://chromium-status.appspot.com/cq/boliu@chromium.org/255783007/1
> >
> >
> > https://codereview.chromium.org/255783007/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Yes. I'll fix it in a follow up. Also occured to me it's not exactly right,
since executeHardwareAction is expected to fail in a software view tree.