android_webview/browser/hardware_renderer.h - Issue 255783007: Leak instead of deadlock if executeHardwareAction fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/hardware_renderer.h

Issue 255783007: Leak instead of deadlock if executeHardwareAction fails (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/hardware_renderer.h

diff --git a/android_webview/browser/hardware_renderer.h b/android_webview/browser/hardware_renderer.h

index 4f226d2890896b9e0ed32c477935a3efa89b2c6e..09580eb5f20e89883ad27e0e514b28585fae7c94 100644

--- a/android_webview/browser/hardware_renderer.h

+++ b/android_webview/browser/hardware_renderer.h

@@ -9,7 +9,9 @@

#include "android_webview/browser/gl_view_renderer_manager.h"

#include "android_webview/browser/shared_renderer_state.h"

+#include "base/lazy_instance.h"

#include "base/memory/ref_counted.h"

+#include "base/threading/thread_local.h"

#include "content/public/browser/android/synchronous_compositor.h"

struct AwDrawGLInfo;

@@ -61,7 +63,7 @@ class ScopedAllowGL {

static bool IsAllowed();

private:

- static bool allow_gl;

+ static base::LazyInstance<base::ThreadLocalBoolean> allow_gl;

DISALLOW_COPY_AND_ASSIGN(ScopedAllowGL);

};