Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Side by Side Diff: android_webview/browser/gl_view_renderer_manager.cc

Issue 255783007: Leak instead of deadlock if executeHardwareAction fails (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/gl_view_renderer_manager.h" 5 #include "android_webview/browser/gl_view_renderer_manager.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/threading/platform_thread.h" 8 #include "base/threading/platform_thread.h"
9 9
10 namespace android_webview { 10 namespace android_webview {
11 11
12 using base::AutoLock; 12 using base::AutoLock;
13 13
14 namespace { 14 namespace {
15 base::LazyInstance<GLViewRendererManager>::Leaky g_view_renderer_manager = 15 base::LazyInstance<GLViewRendererManager>::Leaky g_view_renderer_manager =
16 LAZY_INSTANCE_INITIALIZER; 16 LAZY_INSTANCE_INITIALIZER;
17 } // namespace 17 } // namespace
18 18
19 // static 19 // static
20 GLViewRendererManager* GLViewRendererManager::GetInstance() { 20 GLViewRendererManager* GLViewRendererManager::GetInstance() {
21 return g_view_renderer_manager.Pointer(); 21 return g_view_renderer_manager.Pointer();
22 } 22 }
23 23
24 GLViewRendererManager::GLViewRendererManager() {} 24 GLViewRendererManager::GLViewRendererManager() {}
25 25
26 GLViewRendererManager::~GLViewRendererManager() {} 26 GLViewRendererManager::~GLViewRendererManager() {}
27 27
28 bool GLViewRendererManager::OnRenderThread() const {
29 AutoLock auto_lock(lock_);
30 return render_thread_.is_equal(base::PlatformThread::CurrentHandle());
31 }
32
33 void GLViewRendererManager::MarkRenderThread() {
34 lock_.AssertAcquired();
35 if (render_thread_.is_null())
36 render_thread_ = base::PlatformThread::CurrentHandle();
37 DCHECK(render_thread_.is_equal(base::PlatformThread::CurrentHandle()));
38 }
39
40 GLViewRendererManager::Key GLViewRendererManager::PushBack(RendererType view) { 28 GLViewRendererManager::Key GLViewRendererManager::PushBack(RendererType view) {
41 MarkRenderThread();
42 DCHECK(mru_list_.end() == 29 DCHECK(mru_list_.end() ==
43 std::find(mru_list_.begin(), mru_list_.end(), view)); 30 std::find(mru_list_.begin(), mru_list_.end(), view));
44 mru_list_.push_back(view); 31 mru_list_.push_back(view);
45 Key back = mru_list_.end(); 32 Key back = mru_list_.end();
46 back--; 33 back--;
47 return back; 34 return back;
48 } 35 }
49 36
50 void GLViewRendererManager::DidDrawGL(Key key) { 37 void GLViewRendererManager::DidDrawGL(Key key) {
51 AutoLock auto_lock(lock_); 38 AutoLock auto_lock(lock_);
52 DCHECK(mru_list_.end() != key); 39 DCHECK(mru_list_.end() != key);
53 mru_list_.splice(mru_list_.begin(), mru_list_, key); 40 mru_list_.splice(mru_list_.begin(), mru_list_, key);
54 } 41 }
55 42
56 void GLViewRendererManager::Remove(Key key) { 43 void GLViewRendererManager::Remove(Key key) {
57 AutoLock auto_lock(lock_); 44 AutoLock auto_lock(lock_);
58 DCHECK(mru_list_.end() != key); 45 DCHECK(mru_list_.end() != key);
59 mru_list_.erase(key); 46 mru_list_.erase(key);
60 } 47 }
61 48
62 GLViewRendererManager::RendererType 49 GLViewRendererManager::RendererType
63 GLViewRendererManager::GetMostRecentlyDrawn() const { 50 GLViewRendererManager::GetMostRecentlyDrawn() const {
64 AutoLock auto_lock(lock_); 51 AutoLock auto_lock(lock_);
65 if (mru_list_.begin() == mru_list_.end()) 52 if (mru_list_.begin() == mru_list_.end())
66 return NULL; 53 return NULL;
67 return *mru_list_.begin(); 54 return *mru_list_.begin();
68 } 55 }
69 56
70 } // namespace android_webview 57 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/browser/gl_view_renderer_manager.h ('k') | android_webview/browser/hardware_renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698