Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2552)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 255783007: Leak instead of deadlock if executeHardwareAction fails (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/hardware_renderer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 832e907200321cd42dd710cb3a134a9cc43d91c3..f6eaa03d8489672c89a226c1365aa98c6c420a89 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -1615,16 +1615,16 @@ public class AwContents {
mIsAttachedToWindow = false;
hideAutofillPopup();
if (mNativeAwContents != 0) {
- if (mContainerView.isHardwareAccelerated()) {
- boolean result = mInternalAccessAdapter.executeHardwareAction(new Runnable() {
- @Override
- public void run() {
- nativeReleaseHardwareDrawOnRenderThread(mNativeAwContents);
- }
- });
- if (!result) {
- Log.d(TAG, "executeHardwareAction failed");
+ Runnable releaseHardware = new Runnable() {
+ @Override
+ public void run() {
+ nativeReleaseHardwareDrawOnRenderThread(mNativeAwContents);
}
+ };
+ boolean result = mInternalAccessAdapter.executeHardwareAction(releaseHardware);
+ if (!result) {
+ Log.e(TAG, "May leak or deadlock. Leaked window?");
+ releaseHardware.run();
}
nativeOnDetachedFromWindow(mNativeAwContents);
« no previous file with comments | « android_webview/browser/hardware_renderer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698