Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2564583002:
Upstream Settings.bundle used by experimental_flags.{h,mm}. (Closed)
|
Created:
4 years ago by sdefresne Modified:
4 years ago Reviewers:
rohitrao (ping after 24h) CC:
chromium-reviews, pkl (ping after 24h if needed), arv+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpstream Settings.bundle used by experimental_flags.{h,mm}.
BUG=672516
Committed: https://crrev.com/3dba2c7d25aa994c05516254c4e01a7d7a1967a2
Cr-Commit-Position: refs/heads/master@{#437361}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove obsolete strings file as they are not required. #
Messages
Total messages: 27 (15 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + rohitrao@chromium.org
Please take a look and send to CQ if LGTY.
On 2016/12/08 16:48:46, sdefresne wrote: > Please take a look and send to CQ if LGTY. Note: I checked that the compiled version of .strings file is the same as what UTF-16 encoding gave us, but it make it easier to review changes to those files.
https://codereview.chromium.org/2564583002/diff/1/ios/chrome/browser/resource... File ios/chrome/browser/resources/Settings.bundle/en.lproj/Experimental.strings (right): https://codereview.chromium.org/2564583002/diff/1/ios/chrome/browser/resource... ios/chrome/browser/resources/Settings.bundle/en.lproj/Experimental.strings:1: "Progress Bar" = "Progress Bar"; Do you have any idea what this strings file is for? =) These look like very outdated strings. What happens if we just leave these out?
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/12/08 17:01:05, rohitrao wrote: > lgtm Those files provides translation for the strings in Experimental.plist and Root.plist. I think that if the strings are not present they are not translated. I don't know whether the files are necessary or not. I guess they are not, but maybe they are. I think one of the reason they are obsolete is that they were UTF-16, and thus tools won't see them. I'll try to remove them and if it works without the file, I'll update my CL to remove them.
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rohitrao@chromium.org Link to the patchset: https://codereview.chromium.org/2564583002/#ps20001 (title: "Remove obsolete strings file as they are not required.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sdefresne@chromium.org
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rohitrao@chromium.org Link to the patchset: https://codereview.chromium.org/2564583002/#ps40001 (title: "Remove obsolete strings file as they are not required.")
Thank you for the review. Removed the .strings files as they are not required and obsolete. https://codereview.chromium.org/2564583002/diff/1/ios/chrome/browser/resource... File ios/chrome/browser/resources/Settings.bundle/en.lproj/Experimental.strings (right): https://codereview.chromium.org/2564583002/diff/1/ios/chrome/browser/resource... ios/chrome/browser/resources/Settings.bundle/en.lproj/Experimental.strings:1: "Progress Bar" = "Progress Bar"; On 2016/12/08 17:01:00, rohitrao wrote: > Do you have any idea what this strings file is for? =) These look like very > outdated strings. > > What happens if we just leave these out? Nothing. Removed.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by rohitrao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481228690412260,
"parent_rev": "a91ff3aa21b3c0b3eadcd42621a094aa11561c11", "commit_rev":
"da3b955eed0c86e66a7d483af4acdfc5e8aec32b"}
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from
==========
Upstream Settings.bundle used by experimental_flags.{h,mm}.
BUG=672516
==========
to
==========
Upstream Settings.bundle used by experimental_flags.{h,mm}.
BUG=672516
Committed: https://crrev.com/3dba2c7d25aa994c05516254c4e01a7d7a1967a2
Cr-Commit-Position: refs/heads/master@{#437361}
==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3dba2c7d25aa994c05516254c4e01a7d7a1967a2 Cr-Commit-Position: refs/heads/master@{#437361} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
