Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2556623002: Implement GetIntegerv(SAMPLER_BINDING/TRANSFORM_FEEDBACK_BINDING) in command buffer. (Closed)

Created:
4 years ago by Zhenyao Mo
Modified:
4 years ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement GetIntegerv(SAMPLER_BINDING/TRANSFORM_FEEDBACK_BINDING) in command buffer. It's always return 0 at the moment. WebGL2 is OK because it returns cached value, but we should still make command buffer work for other clients like Skia. Also, remove a unnecessary BindAttribLocation call. BUG=662644 TEST=gpu_unittests R=vmiura@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790 Cr-Commit-Position: refs/heads/master@{#436625}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -19 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 3 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/sampler_manager.h View 2 chunks +6 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/sampler_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/transform_feedback_manager.h View 3 chunks +7 lines, -1 line 0 comments Download
M gpu/command_buffer/service/transform_feedback_manager.cc View 2 chunks +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Zhenyao Mo
vmiura: can you review this (this CL is responding to your TODO comments)?
4 years ago (2016-12-06 01:00:32 UTC) #2
vmiura
lgtm
4 years ago (2016-12-06 02:07:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556623002/20001
4 years ago (2016-12-06 17:19:56 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 17:27:08 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-06 17:29:41 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6aae51477ada40703d4e4db8f9f5336048230790
Cr-Commit-Position: refs/heads/master@{#436625}

Powered by Google App Engine
This is Rietveld 408576698