Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc

Issue 2556623002: Implement GetIntegerv(SAMPLER_BINDING/TRANSFORM_FEEDBACK_BINDING) in command buffer. (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
index 211792c893abaadca178efbe283db3134dfadcd9..5e02f3124a9f2144973344a3a072543cb13a42f6 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
@@ -1534,6 +1534,56 @@ TEST_P(GLES3DecoderTest, GetInteger64i_vValidArgs) {
EXPECT_EQ(GL_NO_ERROR, GetGLError());
}
+TEST_P(GLES3DecoderTest, GetSamplerBinding) {
+ const GLuint kClientID = 12;
+ const GLuint kServiceID = 1012;
+ const GLuint kUnit = 0;
+ DoCreateSampler(kClientID, kServiceID);
+ DoBindSampler(kUnit, kClientID, kServiceID);
+
+ EXPECT_CALL(*gl_, GetError())
+ .WillOnce(Return(GL_NO_ERROR))
+ .WillOnce(Return(GL_NO_ERROR))
+ .RetiresOnSaturation();
+
+ typedef cmds::GetIntegerv::Result Result;
+ Result* result = static_cast<Result*>(shared_memory_address_);
+ cmds::GetIntegerv cmd;
+ cmd.Init(GL_SAMPLER_BINDING, shared_memory_id_, shared_memory_offset_);
+ result->size = 0;
+ EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
+ EXPECT_EQ(1, result->GetNumResults());
+ EXPECT_EQ(kClientID, static_cast<GLuint>(result->GetData()[0]));
+ EXPECT_EQ(GL_NO_ERROR, GetGLError());
+}
+
+TEST_P(GLES3DecoderTest, GetTransformFeedbackBinding) {
+ const GLuint kClientID = 12;
+ const GLuint kServiceID = 1012;
+ const GLenum kTarget = GL_TRANSFORM_FEEDBACK;
+ DoCreateTransformFeedback(kClientID, kServiceID);
+ DoBindTransformFeedback(kTarget, kClientID, kServiceID);
+
+ EXPECT_CALL(*gl_, GetError())
+ .WillOnce(Return(GL_NO_ERROR))
+ .WillOnce(Return(GL_NO_ERROR))
+ .RetiresOnSaturation();
+
+ typedef cmds::GetIntegerv::Result Result;
+ Result* result = static_cast<Result*>(shared_memory_address_);
+ cmds::GetIntegerv cmd;
+ cmd.Init(
+ GL_TRANSFORM_FEEDBACK_BINDING, shared_memory_id_, shared_memory_offset_);
+ result->size = 0;
+ EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
+ EXPECT_EQ(1, result->GetNumResults());
+ EXPECT_EQ(kClientID, static_cast<GLuint>(result->GetData()[0]));
+
+ DoBindTransformFeedback(kTarget, 0, kServiceDefaultTransformFeedbackId);
+ DoDeleteTransformFeedback(kClientID, kServiceID);
+ EXPECT_EQ(GL_NO_ERROR, GetGLError());
+}
+
// Test that processing with 0 entries does nothing.
TEST_P(GLES2DecoderDoCommandsTest, DoCommandsOneOfZero) {
int num_processed = -1;
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698