Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be used

Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be used

- Change frameLoader() to return a reference after DCHECK on m_frame
- Get FrameLoaderClient directly from m_frame when needed than getting
  the FrameLoader and then calling client() on it. FrameLoader::client()
  is just calling m_frame->client().
- Replace code checking nullness of frameLoader() with m_frame
- Use m_frame inside DocumentLoader than calling frame() which doesn't
  add any value.

R=yhirano@chromium.org,tkent@chromium.org
BUG=671533
Review-Url: https://codereview.chromium.org/2556053002
Cr-Commit-Position: refs/heads/master@{#444333}
Committed: https://chromium.googlesource.com/chromium/src/+/78f5a0c23df6926c73cf92839638868e982aae7e

[tyoshino (SeeGerritForStatus), 2016-12-07 10:45:37]

Description was changed from

==========
DocumentLoader

BUG=671533
==========

to

==========
Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be
used

- Change frameLoader() to return a reference after DCHECK on m_frame
- Get FrameLoaderClient directly from m_frame when needed than getting
  the FrameLoader and then calling client() on it. FrameLoader::client()
  is just calling m_frame->client().
- Replace code checking nullness of frameLoader() with m_frame
- Use m_frame inside DocumentLoader than calling frame() which doesn't
  add any value.

BUG=671533
==========

[tyoshino (SeeGerritForStatus), 2016-12-12 16:10:06]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[tyoshino (SeeGerritForStatus), 2016-12-12 16:10:18]

Description was changed from

==========
Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be
used

- Change frameLoader() to return a reference after DCHECK on m_frame
- Get FrameLoaderClient directly from m_frame when needed than getting
  the FrameLoader and then calling client() on it. FrameLoader::client()
  is just calling m_frame->client().
- Replace code checking nullness of frameLoader() with m_frame
- Use m_frame inside DocumentLoader than calling frame() which doesn't
  add any value.

BUG=671533
==========

to

==========
Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be
used

- Change frameLoader() to return a reference after DCHECK on m_frame
- Get FrameLoaderClient directly from m_frame when needed than getting
  the FrameLoader and then calling client() on it. FrameLoader::client()
  is just calling m_frame->client().
- Replace code checking nullness of frameLoader() with m_frame
- Use m_frame inside DocumentLoader than calling frame() which doesn't
  add any value.

BUG=671533
==========

[commit-bot: I haz the power, 2016-12-12 16:10:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 16:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 16:32:55]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[tyoshino (SeeGerritForStatus), 2016-12-13 05:22:36]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[tyoshino (SeeGerritForStatus), 2016-12-13 05:22:44]

tyoshino@chromium.org changed reviewers:
+ yhirano@chromium.org

[commit-bot: I haz the power, 2016-12-13 05:22:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 06:53:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 06:53:06]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-12-26 08:46:24]

https://codereview.chromium.org/2556053002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/2556053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.h:68: class CORE_EXPORT
DocumentLoader
+final

https://codereview.chromium.org/2556053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.h:215: FrameLoaderClient*
frameLoaderClient() const;
What is the reference-pointer policy here? Both frameLoader and
frameLoaderClient cannot be null, according to the DCHECK.

[tyoshino (SeeGerritForStatus), 2017-01-10 10:29:25]

https://codereview.chromium.org/2556053002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/2556053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.h:68: class CORE_EXPORT
DocumentLoader
On 2016/12/26 08:46:23, yhirano wrote:
> +final

WebDataSourceImpl is a subclass of this class.

https://codereview.chromium.org/2556053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.h:215: FrameLoaderClient*
frameLoaderClient() const;
On 2016/12/26 08:46:23, yhirano wrote:
> What is the reference-pointer policy here? Both frameLoader and
> frameLoaderClient cannot be null, according to the DCHECK.

Ah, right. Changed frameLoaderClient() to also be reference returning.

[tyoshino (SeeGerritForStatus), 2017-01-10 10:41:50]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 10:42:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 12:33:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 12:33:40]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-01-11 07:49:04]

lgtm

[tyoshino (SeeGerritForStatus), 2017-01-11 08:01:18]

Description was changed from

==========
Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be
used

- Change frameLoader() to return a reference after DCHECK on m_frame
- Get FrameLoaderClient directly from m_frame when needed than getting
  the FrameLoader and then calling client() on it. FrameLoader::client()
  is just calling m_frame->client().
- Replace code checking nullness of frameLoader() with m_frame
- Use m_frame inside DocumentLoader than calling frame() which doesn't
  add any value.

BUG=671533
==========

to

==========
Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be
used

- Change frameLoader() to return a reference after DCHECK on m_frame
- Get FrameLoaderClient directly from m_frame when needed than getting
  the FrameLoader and then calling client() on it. FrameLoader::client()
  is just calling m_frame->client().
- Replace code checking nullness of frameLoader() with m_frame
- Use m_frame inside DocumentLoader than calling frame() which doesn't
  add any value.

R=yhirano@chromium.org
BUG=671533
==========

[tyoshino (SeeGerritForStatus), 2017-01-11 08:02:11]

tyoshino@chromium.org changed reviewers:
+ tkent@chromium.org

[tyoshino (SeeGerritForStatus), 2017-01-11 08:02:12]

+tkent please review Source/web/

[tkent, 2017-01-11 09:11:55]

lgtm

[tyoshino (SeeGerritForStatus), 2017-01-18 09:33:36]

Description was changed from

==========
Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be
used

- Change frameLoader() to return a reference after DCHECK on m_frame
- Get FrameLoaderClient directly from m_frame when needed than getting
  the FrameLoader and then calling client() on it. FrameLoader::client()
  is just calling m_frame->client().
- Replace code checking nullness of frameLoader() with m_frame
- Use m_frame inside DocumentLoader than calling frame() which doesn't
  add any value.

R=yhirano@chromium.org
BUG=671533
==========

to

==========
Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be
used

- Change frameLoader() to return a reference after DCHECK on m_frame
- Get FrameLoaderClient directly from m_frame when needed than getting
  the FrameLoader and then calling client() on it. FrameLoader::client()
  is just calling m_frame->client().
- Replace code checking nullness of frameLoader() with m_frame
- Use m_frame inside DocumentLoader than calling frame() which doesn't
  add any value.

R=yhirano@chromium.org,tkent@chromium.org
BUG=671533
==========

[tyoshino (SeeGerritForStatus), 2017-01-18 09:33:42]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2017-01-18 09:33:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
yhirano@chromium.org, tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2556053002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-18 09:33:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 11:23:40]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484732022419520,
"parent_rev": "ad61664891105622dd6a46201f97bec138f00f4c", "commit_rev":
"78f5a0c23df6926c73cf92839638868e982aae7e"}

[commit-bot: I haz the power, 2017-01-18 11:24:11]

Description was changed from

==========
Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be
used

- Change frameLoader() to return a reference after DCHECK on m_frame
- Get FrameLoaderClient directly from m_frame when needed than getting
  the FrameLoader and then calling client() on it. FrameLoader::client()
  is just calling m_frame->client().
- Replace code checking nullness of frameLoader() with m_frame
- Use m_frame inside DocumentLoader than calling frame() which doesn't
  add any value.

R=yhirano@chromium.org,tkent@chromium.org
BUG=671533
==========

to

==========
Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be
used

- Change frameLoader() to return a reference after DCHECK on m_frame
- Get FrameLoaderClient directly from m_frame when needed than getting
  the FrameLoader and then calling client() on it. FrameLoader::client()
  is just calling m_frame->client().
- Replace code checking nullness of frameLoader() with m_frame
- Use m_frame inside DocumentLoader than calling frame() which doesn't
  add any value.

R=yhirano@chromium.org,tkent@chromium.org
BUG=671533

Review-Url: https://codereview.chromium.org/2556053002
Cr-Commit-Position: refs/heads/master@{#444333}
Committed:
https://chromium.googlesource.com/chromium/src/+/78f5a0c23df6926c73cf92839638...
==========

[commit-bot: I haz the power, 2017-01-18 11:24:12]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/78f5a0c23df6926c73cf92839638...