Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2556053002: Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be used (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 662 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 if (WebFrameClient* client = m_webFrame->client()) 673 if (WebFrameClient* client = m_webFrame->client())
674 client->didMatchCSS(m_webFrame, WebVector<WebString>(addedSelectors), 674 client->didMatchCSS(m_webFrame, WebVector<WebString>(addedSelectors),
675 WebVector<WebString>(removedSelectors)); 675 WebVector<WebString>(removedSelectors));
676 } 676 }
677 677
678 DocumentLoader* FrameLoaderClientImpl::createDocumentLoader( 678 DocumentLoader* FrameLoaderClientImpl::createDocumentLoader(
679 LocalFrame* frame, 679 LocalFrame* frame,
680 const ResourceRequest& request, 680 const ResourceRequest& request,
681 const SubstituteData& data, 681 const SubstituteData& data,
682 ClientRedirectPolicy clientRedirectPolicy) { 682 ClientRedirectPolicy clientRedirectPolicy) {
683 DCHECK(frame);
684
683 WebDataSourceImpl* ds = 685 WebDataSourceImpl* ds =
684 WebDataSourceImpl::create(frame, request, data, clientRedirectPolicy); 686 WebDataSourceImpl::create(frame, request, data, clientRedirectPolicy);
685 if (m_webFrame->client()) 687 if (m_webFrame->client())
686 m_webFrame->client()->didCreateDataSource(m_webFrame, ds); 688 m_webFrame->client()->didCreateDataSource(m_webFrame, ds);
687 return ds; 689 return ds;
688 } 690 }
689 691
690 String FrameLoaderClientImpl::userAgent() { 692 String FrameLoaderClientImpl::userAgent() {
691 WebString override = 693 WebString override =
692 m_webFrame->client() ? m_webFrame->client()->userAgentOverride() : ""; 694 m_webFrame->client() ? m_webFrame->client()->userAgentOverride() : "";
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
990 WebDevToolsAgentImpl* FrameLoaderClientImpl::devToolsAgent() { 992 WebDevToolsAgentImpl* FrameLoaderClientImpl::devToolsAgent() {
991 return WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot()) 993 return WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot())
992 ->devToolsAgentImpl(); 994 ->devToolsAgentImpl();
993 } 995 }
994 996
995 KURL FrameLoaderClientImpl::overrideFlashEmbedWithHTML(const KURL& url) { 997 KURL FrameLoaderClientImpl::overrideFlashEmbedWithHTML(const KURL& url) {
996 return m_webFrame->client()->overrideFlashEmbedWithHTML(WebURL(url)); 998 return m_webFrame->client()->overrideFlashEmbedWithHTML(WebURL(url));
997 } 999 }
998 1000
999 } // namespace blink 1001 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/EmptyClients.cpp ('k') | third_party/WebKit/Source/web/WebDataSourceImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698