Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: third_party/WebKit/Source/core/loader/EmptyClients.cpp

Issue 2556053002: Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be used (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 140
141 void EmptyFrameLoaderClient::dispatchWillSendSubmitEvent(HTMLFormElement*) {} 141 void EmptyFrameLoaderClient::dispatchWillSendSubmitEvent(HTMLFormElement*) {}
142 142
143 void EmptyFrameLoaderClient::dispatchWillSubmitForm(HTMLFormElement*) {} 143 void EmptyFrameLoaderClient::dispatchWillSubmitForm(HTMLFormElement*) {}
144 144
145 DocumentLoader* EmptyFrameLoaderClient::createDocumentLoader( 145 DocumentLoader* EmptyFrameLoaderClient::createDocumentLoader(
146 LocalFrame* frame, 146 LocalFrame* frame,
147 const ResourceRequest& request, 147 const ResourceRequest& request,
148 const SubstituteData& substituteData, 148 const SubstituteData& substituteData,
149 ClientRedirectPolicy clientRedirectPolicy) { 149 ClientRedirectPolicy clientRedirectPolicy) {
150 DCHECK(frame);
151
150 return DocumentLoader::create(frame, request, substituteData, 152 return DocumentLoader::create(frame, request, substituteData,
151 clientRedirectPolicy); 153 clientRedirectPolicy);
152 } 154 }
153 155
154 LocalFrame* EmptyFrameLoaderClient::createFrame(const FrameLoadRequest&, 156 LocalFrame* EmptyFrameLoaderClient::createFrame(const FrameLoadRequest&,
155 const AtomicString&, 157 const AtomicString&,
156 HTMLFrameOwnerElement*) { 158 HTMLFrameOwnerElement*) {
157 return nullptr; 159 return nullptr;
158 } 160 }
159 161
(...skipping 28 matching lines...) Expand all
188 return nullptr; 190 return nullptr;
189 } 191 }
190 192
191 std::unique_ptr<WebApplicationCacheHost> 193 std::unique_ptr<WebApplicationCacheHost>
192 EmptyFrameLoaderClient::createApplicationCacheHost( 194 EmptyFrameLoaderClient::createApplicationCacheHost(
193 WebApplicationCacheHostClient*) { 195 WebApplicationCacheHostClient*) {
194 return nullptr; 196 return nullptr;
195 } 197 }
196 198
197 } // namespace blink 199 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('k') | third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698