Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2556043002: Avoid WTF::Vector::at() and operator[] in core/html. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, kinuko+watch, loading-reviews+parser_chromium.org, mlamouri+watch-blink_chromium.org, nessy, Srirama, tfarina, vcarbune.chromium, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid WTF::Vector::at() and operator[] in core/html. at() and operator[] are slow due to RELEASE_ASSERT. We can avoid the slowness by range-based |for|. This CL has no behavior changes except runtime performance. BUG=668300 Committed: https://crrev.com/f5775c2f04c255de2fe9f68ff8444d3f987901a4 Cr-Commit-Position: refs/heads/master@{#437175}

Patch Set 1 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -192 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCollection.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp View 3 chunks +5 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 7 chunks +18 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/PublicURLManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/EmailInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.cpp View 2 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FormController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportTreeRoot.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/CueTimeline.cpp View 6 chunks +37 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackList.cpp View 3 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackListBase.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTRegionList.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
tkent
hayato@, would you review this please?
4 years ago (2016-12-08 00:47:31 UTC) #9
hayato
lgtm
4 years ago (2016-12-08 03:06:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556043002/20001
4 years ago (2016-12-08 04:07:28 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-08 04:13:37 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-08 04:18:00 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5775c2f04c255de2fe9f68ff8444d3f987901a4
Cr-Commit-Position: refs/heads/master@{#437175}

Powered by Google App Engine
This is Rietveld 408576698