Avoid WTF::Vector::at() and operator[] in core/html.

third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 90 matching lines @@
   HTMLCollection::invalidateCache(oldDocument);
   m_cachedElement = nullptr;
   m_cachedElementOffsetInArray = 0;
 }
 
 static HTMLElement* firstNamedItem(const ListedElement::List& elementsArray,
                                    const QualifiedName& attrName,
                                    const String& name) {
   DCHECK(attrName == idAttr || attrName == nameAttr);
 
-  for (unsigned i = 0; i < elementsArray.size(); ++i) {
-    HTMLElement* element = toHTMLElement(elementsArray[i]);
-    if (elementsArray[i]->isEnumeratable() &&
+  for (const auto& listedElement : elementsArray) {
+    HTMLElement* element = toHTMLElement(listedElement);
+    if (listedElement->isEnumeratable() &&
         element->fastGetAttribute(attrName) == name)
       return element;
   }
   return nullptr;
 }
 
 HTMLElement* HTMLFormControlsCollection::namedItem(
     const AtomicString& name) const {
   // http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/nameditem.asp
   // This method first searches for an object with a matching id
   // attribute. If a match is not found, the method then searches for an
   // object with a matching name attribute, but only on those elements
   // that are allowed a name attribute.
   if (HTMLElement* item = firstNamedItem(listedElements(), idAttr, name))
     return item;
   return firstNamedItem(listedElements(), nameAttr, name);
 }
 
 void HTMLFormControlsCollection::updateIdNameCache() const {
   if (hasValidIdNameCache())
     return;
 
   NamedItemCache* cache = NamedItemCache::create();
   HashSet<StringImpl*> foundInputElements;
 
-  const ListedElement::List& elementsArray = listedElements();
-
-  for (unsigned i = 0; i < elementsArray.size(); ++i) {
-    ListedElement* listedElement = elementsArray[i];
+  for (const auto& listedElement : listedElements()) {
     if (listedElement->isEnumeratable()) {
       HTMLElement* element = toHTMLElement(listedElement);
       const AtomicString& idAttrVal = element->getIdAttribute();
       const AtomicString& nameAttrVal = element->getNameAttribute();
       if (!idAttrVal.isEmpty()) {
         cache->addElementWithId(idAttrVal, element);
         foundInputElements.add(idAttrVal.impl());
       }
       if (!nameAttrVal.isEmpty() && idAttrVal != nameAttrVal) {
         cache->addElementWithName(nameAttrVal, element);
         foundInputElements.add(nameAttrVal.impl());
       }
     }
   }
 
   // HTMLFormControlsCollection doesn't support named getter for IMG
   // elements. However we still need to handle IMG elements here because
   // HTMLFormElement named getter relies on this.
-  const HeapVector<Member<HTMLImageElement>>& imageElementsArray =
-      formImageElements();
-  for (unsigned i = 0; i < imageElementsArray.size(); ++i) {
-    HTMLImageElement* element = imageElementsArray[i];
+  for (const auto& element : formImageElements()) {
     const AtomicString& idAttrVal = element->getIdAttribute();
     const AtomicString& nameAttrVal = element->getNameAttribute();
     if (!idAttrVal.isEmpty() && !foundInputElements.contains(idAttrVal.impl()))
       cache->addElementWithId(idAttrVal, element);
     if (!nameAttrVal.isEmpty() && idAttrVal != nameAttrVal &&
         !foundInputElements.contains(nameAttrVal.impl()))
       cache->addElementWithName(nameAttrVal, element);
   }
 
   // Set the named item cache last as traversing the tree may cause cache
@@ skipping 49 matching lines @@
     }
   }
 }
 
 DEFINE_TRACE(HTMLFormControlsCollection) {
   visitor->trace(m_cachedElement);
   HTMLCollection::trace(visitor);
 }
 
 }  // namespace blink