Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

Issue 2556043002: Avoid WTF::Vector::at() and operator[] in core/html. (Closed)
Patch Set: _ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp b/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp
index ba949984832585d161c0f826caac42ef706a485d..df0366dc22eec021b0f59f13a05ac12e95dd7c73 100644
--- a/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp
@@ -535,8 +535,8 @@ void DateTimeEditElement::addField(DateTimeFieldElement* field) {
}
bool DateTimeEditElement::anyEditableFieldsHaveValues() const {
- for (size_t fieldIndex = 0; fieldIndex < m_fields.size(); ++fieldIndex) {
- if (!m_fields[fieldIndex]->isDisabled() && m_fields[fieldIndex]->hasValue())
+ for (const auto& field : m_fields) {
+ if (!field->isDisabled() && field->hasValue())
return true;
}
return false;
@@ -767,8 +767,8 @@ void DateTimeEditElement::readOnlyStateChanged() {
}
void DateTimeEditElement::resetFields() {
- for (size_t fieldIndex = 0; fieldIndex < m_fields.size(); ++fieldIndex)
- m_fields[fieldIndex]->removeEventHandler();
+ for (const auto& field : m_fields)
+ field->removeEventHandler();
m_fields.shrink(0);
}
@@ -788,22 +788,22 @@ void DateTimeEditElement::setValueAsDate(
const LayoutParameters& layoutParameters,
const DateComponents& date) {
layout(layoutParameters, date);
- for (size_t fieldIndex = 0; fieldIndex < m_fields.size(); ++fieldIndex)
- m_fields[fieldIndex]->setValueAsDate(date);
+ for (const auto& field : m_fields)
+ field->setValueAsDate(date);
}
void DateTimeEditElement::setValueAsDateTimeFieldsState(
const DateTimeFieldsState& dateTimeFieldsState) {
- for (size_t fieldIndex = 0; fieldIndex < m_fields.size(); ++fieldIndex)
- m_fields[fieldIndex]->setValueAsDateTimeFieldsState(dateTimeFieldsState);
+ for (const auto& field : m_fields)
+ field->setValueAsDateTimeFieldsState(dateTimeFieldsState);
}
void DateTimeEditElement::setEmptyValue(
const LayoutParameters& layoutParameters,
const DateComponents& dateForReadOnlyField) {
layout(layoutParameters, dateForReadOnlyField);
- for (size_t fieldIndex = 0; fieldIndex < m_fields.size(); ++fieldIndex)
- m_fields[fieldIndex]->setEmptyValue(DateTimeFieldElement::DispatchNoEvent);
+ for (const auto& field : m_fields)
+ field->setEmptyValue(DateTimeFieldElement::DispatchNoEvent);
}
bool DateTimeEditElement::hasFocusedField() {
@@ -850,8 +850,8 @@ String DateTimeEditElement::value() const {
DateTimeFieldsState DateTimeEditElement::valueAsDateTimeFieldsState() const {
DateTimeFieldsState dateTimeFieldsState;
- for (size_t fieldIndex = 0; fieldIndex < m_fields.size(); ++fieldIndex)
- m_fields[fieldIndex]->populateDateTimeFieldsState(dateTimeFieldsState);
+ for (const auto& field : m_fields)
+ field->populateDateTimeFieldsState(dateTimeFieldsState);
return dateTimeFieldsState;
}

Powered by Google App Engine
This is Rietveld 408576698