third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h - Issue 2556043002: Avoid WTF::Vector::at() and operator[] in core/html.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

Issue 2556043002: Avoid WTF::Vector::at() and operator[] in core/html. (Closed)

Patch Set: _ Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

diff --git a/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h b/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

index 514c955371ce1f188dc82fb2adcaf0607febe8eb..fb6d1a081c8ad8f9883b56a94adf8a29e09e7fb9 100644

--- a/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

+++ b/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

@@ -222,8 +222,7 @@ inline void AtomicHTMLToken::initializeAttributes(

m_attributes.clear();

m_attributes.reserveInitialCapacity(size);

- for (size_t i = 0; i < size; ++i) {

- const HTMLToken::Attribute& attribute = attributes[i];

+ for (const auto& attribute : attributes) {

if (attribute.nameAsVector().isEmpty())

continue;