Make InvalidatableInterpolation's InterpolationTypes decided at effect application time

Make InvalidatableInterpolation's InterpolationTypes decided at effect application time

This patch replaces PropertyInterpolationTypesMapping with CSS and SVG
InterpolationTypesMap classes that are provided to InvalidatableInterpolation
objects via the InterpolationEnvironment.

InvalidatableInterpolations are no longer provided with the list of
InterpolationTypes at construction, now they retrieve the list at effect
application time during applyStack().

This is in preparation for supporting smooth animation of registered
custom properties.

BUG=671904
Committed: https://crrev.com/3ac8b90fcbda4c6e3ef484140751cd0341b31c48
Committed: https://crrev.com/dbf9ff76db17cc97436ee43a53ff269af3a45231
Committed: https://crrev.com/87ec6842397ca213e3216de27dd2a156ea01a342
Cr-Original-Original-Commit-Position: refs/heads/master@{#437381}
Cr-Original-Commit-Position: refs/heads/master@{#437474}
Cr-Commit-Position: refs/heads/master@{#437504}

[alancutter (OOO until 2018), 2016-12-07 06:26:20]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[Eric Willigers, 2016-12-07 22:49:49]

lgtm

https://codereview.chromium.org/2555923003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/InterpolationEnvironment.h
(right):

https://codereview.chromium.org/2555923003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/InterpolationEnvironment.h:18: class
InterpolationEnvironment {
Can we disallow copying?

[alancutter (OOO until 2018), 2016-12-07 23:15:53]

https://codereview.chromium.org/2555923003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/InterpolationEnvironment.h
(right):

https://codereview.chromium.org/2555923003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/InterpolationEnvironment.h:18: class
InterpolationEnvironment {
On 2016/12/07 at 22:49:49, Eric Willigers wrote:
> Can we disallow copying?

I think it's fine for this to be copied if it happens to be necessary.

[alancutter (OOO until 2018), 2016-12-07 23:15:56]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-12-07 23:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 23:16:48]

This CL has an open dependency (Issue 2555103002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[alancutter (OOO until 2018), 2016-12-08 01:47:37]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:48:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:59:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:59:13]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alancutter (OOO until 2018), 2016-12-08 02:12:11]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[alancutter (OOO until 2018), 2016-12-08 02:12:11]

+timloh for PropertyRegistry.h and core/.

[alancutter (OOO until 2018), 2016-12-08 03:36:05]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 03:36:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2016-12-08 03:37:18]

On 2016/12/08 02:12:11, alancutter wrote:
> +timloh for PropertyRegistry.h and core/.

lgtm

[alancutter (OOO until 2018), 2016-12-08 03:45:32]

The CQ bit was unchecked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-12-08 03:45:34]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-12-08 03:45:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2555923003/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-08 03:45:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 04:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 04:56:12]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[alancutter (OOO until 2018), 2016-12-08 05:21:57]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-12-08 05:22:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 06:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 06:46:10]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[alancutter (OOO until 2018), 2016-12-08 22:25:50]

On 2016/12/08 at 06:46:10, commit-bot wrote:
> Try jobs failed on following builders:
>   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

"junit.framework.AssertionFailedError: Shell is still loading." ):

[alancutter (OOO until 2018), 2016-12-08 22:25:55]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-12-08 22:26:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 22:51:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481235955903490,
"parent_rev": "2729c417ef1ca0f2f1e8626e60d7e734dc5f6a0e", "commit_rev":
"ff321926141b204dda8c53e91cbdf5af8bf16321"}

[commit-bot: I haz the power, 2016-12-08 22:51:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-08 22:55:18]

Description was changed from

==========
Make InvalidatableInterpolation's InterpolationTypes decided at effect
application time

This patch replaces PropertyInterpolationTypesMapping with CSS and SVG
InterpolationTypesMap classes that are provided to InvalidatableInterpolation
objects via the InterpolationEnvironment.

InvalidatableInterpolations are no longer provided with the list of
InterpolationTypes at construction, now they retrieve the list at effect
application time during applyStack().

This is in preparation for supporting smooth animation of registered
custom properties.

BUG=671904
==========

to

==========
Make InvalidatableInterpolation's InterpolationTypes decided at effect
application time

This patch replaces PropertyInterpolationTypesMapping with CSS and SVG
InterpolationTypesMap classes that are provided to InvalidatableInterpolation
objects via the InterpolationEnvironment.

InvalidatableInterpolations are no longer provided with the list of
InterpolationTypes at construction, now they retrieve the list at effect
application time during applyStack().

This is in preparation for supporting smooth animation of registered
custom properties.

BUG=671904

Committed: https://crrev.com/3ac8b90fcbda4c6e3ef484140751cd0341b31c48
Cr-Commit-Position: refs/heads/master@{#437381}
==========

[commit-bot: I haz the power, 2016-12-08 22:55:19]

Patchset 3 (id:??) landed as
https://crrev.com/3ac8b90fcbda4c6e3ef484140751cd0341b31c48
Cr-Commit-Position: refs/heads/master@{#437381}

[alancutter (OOO until 2018), 2016-12-08 23:13:21]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2567453002/ by alancutter@chromium.org.

The reason for reverting is: Broke the mac compile bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%....

[findit-for-me, 2016-12-08 23:15:31]

FYI: Findit identified this CL at revision 437381 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[alancutter (OOO until 2018), 2016-12-08 23:23:36]

On 2016/12/08 at 23:13:21, alancutter wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2567453002/ by alancutter@chromium.org.
> 
> The reason for reverting is: Broke the mac compile bot:
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%....

Mini post mortem:
The flaky failures of android_n5x_swarming_rel delayed this patch from
committing for ~1 day. In the meantime another change landed that, together with
this patch, fails to compile. The patch landed anyway because ~1 day old try bot
results were sufficient to pass CQ checks.

[alancutter (OOO until 2018), 2016-12-09 03:38:39]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-12-09 03:38:40]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2555923003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-09 03:39:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 05:15:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481254719707920,
"parent_rev": "819514b6189dfc3b0dc6443bcaec585d1e594eb1", "commit_rev":
"59aa463060472f2556fbec2221eb9bc1cee750cc"}

[commit-bot: I haz the power, 2016-12-09 05:16:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-09 05:20:21]

Description was changed from

==========
Make InvalidatableInterpolation's InterpolationTypes decided at effect
application time

This patch replaces PropertyInterpolationTypesMapping with CSS and SVG
InterpolationTypesMap classes that are provided to InvalidatableInterpolation
objects via the InterpolationEnvironment.

InvalidatableInterpolations are no longer provided with the list of
InterpolationTypes at construction, now they retrieve the list at effect
application time during applyStack().

This is in preparation for supporting smooth animation of registered
custom properties.

BUG=671904

Committed: https://crrev.com/3ac8b90fcbda4c6e3ef484140751cd0341b31c48
Cr-Commit-Position: refs/heads/master@{#437381}
==========

to

==========
Make InvalidatableInterpolation's InterpolationTypes decided at effect
application time

This patch replaces PropertyInterpolationTypesMapping with CSS and SVG
InterpolationTypesMap classes that are provided to InvalidatableInterpolation
objects via the InterpolationEnvironment.

InvalidatableInterpolations are no longer provided with the list of
InterpolationTypes at construction, now they retrieve the list at effect
application time during applyStack().

This is in preparation for supporting smooth animation of registered
custom properties.

BUG=671904

Committed: https://crrev.com/3ac8b90fcbda4c6e3ef484140751cd0341b31c48
Committed: https://crrev.com/dbf9ff76db17cc97436ee43a53ff269af3a45231
Cr-Original-Commit-Position: refs/heads/master@{#437381}
Cr-Commit-Position: refs/heads/master@{#437474}
==========

[commit-bot: I haz the power, 2016-12-09 05:20:23]

Patchset 4 (id:??) landed as
https://crrev.com/dbf9ff76db17cc97436ee43a53ff269af3a45231
Cr-Commit-Position: refs/heads/master@{#437474}

[yhirano, 2016-12-09 06:20:21]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2562933002/ by yhirano@chromium.org.

The reason for reverting is: Speculative revert for mass animation layout tests
failures..

[alancutter (OOO until 2018), 2016-12-09 07:52:19]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-12-09 07:52:20]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2555923003/#ps80001
(title: "Extended InterpolationTypesMap lifetime scope to fix release crash")

[commit-bot: I haz the power, 2016-12-09 07:52:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 09:42:29]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481269939885580,
"parent_rev": "676dc20a124203fc59f876a84fec92838e67f369", "commit_rev":
"85451da397b36fbcb497a526f6c70afb1a6577ce"}

[commit-bot: I haz the power, 2016-12-09 09:42:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-09 09:45:41]

Description was changed from

==========
Make InvalidatableInterpolation's InterpolationTypes decided at effect
application time

This patch replaces PropertyInterpolationTypesMapping with CSS and SVG
InterpolationTypesMap classes that are provided to InvalidatableInterpolation
objects via the InterpolationEnvironment.

InvalidatableInterpolations are no longer provided with the list of
InterpolationTypes at construction, now they retrieve the list at effect
application time during applyStack().

This is in preparation for supporting smooth animation of registered
custom properties.

BUG=671904

Committed: https://crrev.com/3ac8b90fcbda4c6e3ef484140751cd0341b31c48
Committed: https://crrev.com/dbf9ff76db17cc97436ee43a53ff269af3a45231
Cr-Original-Commit-Position: refs/heads/master@{#437381}
Cr-Commit-Position: refs/heads/master@{#437474}
==========

to

==========
Make InvalidatableInterpolation's InterpolationTypes decided at effect
application time

This patch replaces PropertyInterpolationTypesMapping with CSS and SVG
InterpolationTypesMap classes that are provided to InvalidatableInterpolation
objects via the InterpolationEnvironment.

InvalidatableInterpolations are no longer provided with the list of
InterpolationTypes at construction, now they retrieve the list at effect
application time during applyStack().

This is in preparation for supporting smooth animation of registered
custom properties.

BUG=671904

Committed: https://crrev.com/3ac8b90fcbda4c6e3ef484140751cd0341b31c48
Committed: https://crrev.com/dbf9ff76db17cc97436ee43a53ff269af3a45231
Committed: https://crrev.com/87ec6842397ca213e3216de27dd2a156ea01a342
Cr-Original-Original-Commit-Position: refs/heads/master@{#437381}
Cr-Original-Commit-Position: refs/heads/master@{#437474}
Cr-Commit-Position: refs/heads/master@{#437504}
==========

[commit-bot: I haz the power, 2016-12-09 09:45:42]

Patchset 5 (id:??) landed as
https://crrev.com/87ec6842397ca213e3216de27dd2a156ea01a342
Cr-Commit-Position: refs/heads/master@{#437504}

[martiniss, 2016-12-09 14:59:15]

On 2016/12/08 at 23:23:36, alancutter wrote:
> On 2016/12/08 at 23:13:21, alancutter wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2567453002/ by alancutter@chromium.org.
> > 
> > The reason for reverting is: Broke the mac compile bot:
> >
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%....
> 
> Mini post mortem:
> The flaky failures of android_n5x_swarming_rel delayed this patch from
committing for ~1 day. In the meantime another change landed that, together with
this patch, fails to compile. The patch landed anyway because ~1 day old try bot
results were sufficient to pass CQ checks.

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=672846 to get this
investigated.

[agrieve, 2016-12-13 15:39:00]

On 2016/12/09 14:59:15, martiniss wrote:
> On 2016/12/08 at 23:23:36, alancutter wrote:
> > On 2016/12/08 at 23:13:21, alancutter wrote:
> > > A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2567453002/ by mailto:alancutter@chromium.org.
> > > 
> > > The reason for reverting is: Broke the mac compile bot:
> > >
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%....
> > 
> > Mini post mortem:
> > The flaky failures of android_n5x_swarming_rel delayed this patch from
> committing for ~1 day. In the meantime another change landed that, together
with
> this patch, fails to compile. The patch landed anyway because ~1 day old try
bot
> results were sufficient to pass CQ checks.
> 
> Filed https://bugs.chromium.org/p/chromium/issues/detail?id=672846 to get this
> investigated.

Note: This change reduced ChromeModern.apk by 70kb! Yay (assuming a reland will
eventually happen)

[alancutter (OOO until 2018), 2016-12-13 23:32:55]

On 2016/12/13 at 15:39:00, agrieve wrote:
> On 2016/12/09 14:59:15, martiniss wrote:
> > On 2016/12/08 at 23:23:36, alancutter wrote:
> > > On 2016/12/08 at 23:13:21, alancutter wrote:
> > > > A revert of this CL (patchset #3 id:40001) has been created in
> > https://codereview.chromium.org/2567453002/ by
mailto:alancutter@chromium.org.
> > > > 
> > > > The reason for reverting is: Broke the mac compile bot:
> > > >
> >
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%....
> > > 
> > > Mini post mortem:
> > > The flaky failures of android_n5x_swarming_rel delayed this patch from
> > committing for ~1 day. In the meantime another change landed that, together
with
> > this patch, fails to compile. The patch landed anyway because ~1 day old try
bot
> > results were sufficient to pass CQ checks.
> > 
> > Filed https://bugs.chromium.org/p/chromium/issues/detail?id=672846 to get
this
> > investigated.
> 
> Note: This change reduced ChromeModern.apk by 70kb! Yay (assuming a reland
will eventually happen)

This change has landed (third time was lucky). I'm very very skeptical about a
70kb size reduction though, this change is more or less just moving code around.